test suite reviews and discussions
 help / color / mirror / Atom feed
From: Ke Xu <ke1.xu@intel.com>
To: dts@dpdk.org
Cc: lijuan.tu@intel.com, yuan.peng@intel.com, ke1.xu@intel.com
Subject: [DTS][PATCH V3 3/3] tests/vf_offload: implement packets count, super-long packet and random payload.
Date: Wed,  4 Jan 2023 15:20:53 +0800	[thread overview]
Message-ID: <20230104072053.86366-4-ke1.xu@intel.com> (raw)
In-Reply-To: <20230104072053.86366-1-ke1.xu@intel.com>

Implemented packets count that sends multiple packets of one packet combination.

Implemented random payload.

Added super-long packet of payload length of 8500.

Signed-off-by: Ke Xu <ke1.xu@intel.com>
---
 tests/TestSuite_vf_offload.py | 150 ++++++++++++++++++++++++++++------
 1 file changed, 125 insertions(+), 25 deletions(-)

diff --git a/tests/TestSuite_vf_offload.py b/tests/TestSuite_vf_offload.py
index 7a55c791..a212133c 100644
--- a/tests/TestSuite_vf_offload.py
+++ b/tests/TestSuite_vf_offload.py
@@ -646,7 +646,17 @@ class TestVfOffload(TestCase):
             self.tester.get_local_port(self.dut_ports[1])
         )
 
-        self.loading_sizes = [128, 800, 801, 1700, 2500]
+        # Here size_and_count is a list of tuples for the test scopes that
+        # in a tuple (size, count) means, sending packets for count times
+        # for TSO with a payload size of size.
+        self.size_and_count = [
+            (128, 10),
+            (800, 10),
+            (801, 10),
+            (1700, 10),
+            (2500, 10),
+            (8500, 1000),
+        ]
 
         self.tester.send_expect(
             "ethtool -K %s rx off tx off tso off gso off gro off lro off"
@@ -720,13 +730,13 @@ class TestVfOffload(TestCase):
         self.tester.scapy_foreground()
         time.sleep(5)
 
-        for loading_size in self.loading_sizes:
+        for loading_size, packet_count in self.size_and_count:
             # IPv4 tcp test
             out = self.vm0_testpmd.execute_cmd("clear port info all", "testpmd> ", 120)
             self.tcpdump_start_sniffing([tx_interface, rx_interface])
             self.tester.scapy_append(
-                'sendp([Ether(dst="%s",src="52:00:00:00:00:00")/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/("X"*%s)], iface="%s")'
-                % (mac, loading_size, tx_interface)
+                'sendp([Ether(dst="%s",src="52:00:00:00:00:00")/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface="%s", count=%s)'
+                % (mac, loading_size, tx_interface, packet_count)
             )
             out = self.tester.scapy_execute()
             out = self.vm0_testpmd.execute_cmd("show port stats all")
@@ -738,29 +748,49 @@ class TestVfOffload(TestCase):
             self.logger.info(payload_size_list)
             if loading_size <= 800:
                 self.verify(
-                    rx_stats == tx_stats and int(payload_size_list[0]) == loading_size,
+                    # for all packet_count packets, verifying the packet size equals the size we sent.
+                    rx_stats == tx_stats
+                    and all(
+                        [
+                            int(payload_size_list[0]) == loading_size
+                            for j in range(packet_count)
+                        ]
+                    ),
                     "IPV4 RX or TX packet number not correct",
                 )
             else:
                 num = loading_size // 800
                 for i in range(num):
                     self.verify(
-                        int(payload_size_list[i]) == 800,
+                        # i * packet_count + j is the i-th segmentation for j-th packet.
+                        all(
+                            [
+                                int(payload_size_list[i * packet_count + j]) == 800
+                                for j in range(packet_count)
+                            ]
+                        ),
                         "the packet segmentation incorrect, %s" % payload_size_list,
                     )
                 if loading_size % 800 != 0:
                     self.verify(
-                        int(payload_size_list[num]) == loading_size % 800,
+                        # num * packet_count + j is the last segmentation for j-th packet.
+                        all(
+                            [
+                                int(payload_size_list[num * packet_count + j])
+                                == loading_size % 800
+                                for j in range(packet_count)
+                            ]
+                        ),
                         "the packet segmentation incorrect, %s" % payload_size_list,
                     )
 
-        for loading_size in self.loading_sizes:
+        for loading_size, packet_count in self.size_and_count:
             # IPv6 tcp test
             out = self.vm0_testpmd.execute_cmd("clear port info all", "testpmd> ", 120)
             self.tcpdump_start_sniffing([tx_interface, rx_interface])
             self.tester.scapy_append(
-                'sendp([Ether(dst="%s", src="52:00:00:00:00:00")/IPv6(src="FE80:0:0:0:200:1FF:FE00:200", dst="3555:5555:6666:6666:7777:7777:8888:8888")/TCP(sport=1021,dport=1021)/("X"*%s)], iface="%s")'
-                % (mac, loading_size, tx_interface)
+                'sendp([Ether(dst="%s", src="52:00:00:00:00:00")/IPv6(src="FE80:0:0:0:200:1FF:FE00:200", dst="3555:5555:6666:6666:7777:7777:8888:8888")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface="%s", count=%s)'
+                % (mac, loading_size, tx_interface, packet_count)
             )
             out = self.tester.scapy_execute()
             out = self.vm0_testpmd.execute_cmd("show port stats all")
@@ -772,19 +802,39 @@ class TestVfOffload(TestCase):
             self.logger.info(payload_size_list)
             if loading_size <= 800:
                 self.verify(
-                    rx_stats == tx_stats and int(payload_size_list[0]) == loading_size,
+                    # for all packet_count packets, verifying the packet size equals the size we sent.
+                    rx_stats == tx_stats
+                    and all(
+                        [
+                            int(payload_size_list[j]) == loading_size
+                            for j in range(packet_count)
+                        ]
+                    ),
                     "IPV6 RX or TX packet number not correct",
                 )
             else:
                 num = loading_size // 800
                 for i in range(num):
                     self.verify(
-                        int(payload_size_list[i]) == 800,
+                        # i * packet_count + j is the i-th segmentation for j-th packet.
+                        all(
+                            [
+                                int(payload_size_list[i * packet_count + j]) == 800
+                                for j in range(packet_count)
+                            ]
+                        ),
                         "the packet segmentation incorrect, %s" % payload_size_list,
                     )
                 if loading_size % 800 != 0:
                     self.verify(
-                        int(payload_size_list[num]) == loading_size % 800,
+                        # num * packet_count + j is the last segmentation for j-th packet.
+                        all(
+                            [
+                                int(payload_size_list[num * packet_count + j])
+                                == loading_size % 800
+                                for j in range(packet_count)
+                            ]
+                        ),
                         "the packet segmentation incorrect, %s" % payload_size_list,
                     )
 
@@ -803,7 +853,17 @@ class TestVfOffload(TestCase):
             self.tester.get_local_port(self.vm0_dut_ports[1])
         )
 
-        self.loading_sizes = [128, 800, 801, 1700, 2500]
+        # Here size_and_count is a list of tuples for the test scopes that
+        # in a tuple (size, count) means, sending packets for count times
+        # for TSO with a payload size of size.
+        self.size_and_count = [
+            (128, 10),
+            (800, 10),
+            (801, 10),
+            (1700, 10),
+            (2500, 10),
+            (8500, 1000),
+        ]
 
         self.tester.send_expect(
             "ethtool -K %s rx off tx off tso off gso off gro off lro off"
@@ -860,7 +920,7 @@ class TestVfOffload(TestCase):
         time.sleep(5)
 
         for key_outer in pkts_outer:
-            for loading_size in self.loading_sizes:
+            for loading_size, packet_count in self.size_and_count:
                 # IPv4 tcp test
                 out = self.vm0_testpmd.execute_cmd(
                     "clear port info all", "testpmd> ", 120
@@ -874,9 +934,9 @@ class TestVfOffload(TestCase):
                     (
                         'sendp([Ether(dst="%s",src="52:00:00:00:00:00")/'
                         + pkts_outer[key_outer]
-                        + '/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/("X"*%s)], iface="%s")'
+                        + '/IP(src="192.168.1.1",dst="192.168.1.2")/TCP(sport=1021,dport=1021)/Raw(RandString(size=%s))], iface="%s", count = %s)'
                     )
-                    % (mac, loading_size, tx_interface)
+                    % (mac, loading_size, tx_interface, packet_count)
                 )
                 out = self.tester.scapy_execute()
                 out = self.vm0_testpmd.execute_cmd("show port stats all")
@@ -888,23 +948,43 @@ class TestVfOffload(TestCase):
                 self.logger.info(payload_size_list)
                 if loading_size <= 800:
                     self.verify(
-                        rx_stats == tx_stats and payload_size_list[0] == loading_size,
+                        # for all packet_count packets, verifying the packet size equals the size we sent.
+                        rx_stats == tx_stats
+                        and all(
+                            [
+                                payload_size_list == loading_size
+                                for j in range(packet_count)
+                            ]
+                        ),
                         f"{key_outer} tunnel IPV4 RX or TX packet number not correct",
                     )
                 else:
                     num = loading_size // 800
                     for i in range(num):
                         self.verify(
-                            payload_size_list[i] == 800,
+                            # i * packet_count + j is the i-th segmentation for j-th packet.
+                            all(
+                                [
+                                    payload_size_list[i * packet_count + j] == 800
+                                    for j in range(packet_count)
+                                ]
+                            ),
                             "the packet segmentation incorrect, %s" % payload_size_list,
                         )
                     if loading_size % 800 != 0:
                         self.verify(
-                            payload_size_list[num] == loading_size % 800,
+                            # num * packet_count + j is the last segmentation for j-th packet.
+                            all(
+                                [
+                                    payload_size_list[num * packet_count + j]
+                                    == loading_size % 800
+                                    for j in range(packet_count)
+                                ]
+                            ),
                             "the packet segmentation incorrect, %s" % payload_size_list,
                         )
 
-            for loading_size in self.loading_sizes:
+            for loading_size, packet_count in self.size_and_count:
                 # IPv6 tcp test
                 out = self.vm0_testpmd.execute_cmd(
                     "clear port info all", "testpmd> ", 120
@@ -920,7 +1000,7 @@ class TestVfOffload(TestCase):
                         + pkts_outer[key_outer]
                         + '/IPv6(src="FE80:0:0:0:200:1FF:FE00:200", dst="3555:5555:6666:6666:7777:7777:8888:8888")/TCP(sport=1021,dport=1021)/("X"*%s)], iface="%s")'
                     )
-                    % (mac, loading_size, tx_interface)
+                    % (mac, loading_size, tx_interface, packet_count)
                 )
                 out = self.tester.scapy_execute()
                 out = self.vm0_testpmd.execute_cmd("show port stats all")
@@ -932,19 +1012,39 @@ class TestVfOffload(TestCase):
                 self.logger.info(payload_size_list)
                 if loading_size <= 800:
                     self.verify(
-                        rx_stats == tx_stats and payload_size_list[0] == loading_size,
+                        # for all packet_count packets, verifying the packet size equals the size we sent.
+                        rx_stats == tx_stats
+                        and all(
+                            [
+                                payload_size_list[j] == loading_size
+                                for j in range(packet_count)
+                            ]
+                        ),
                         f"{key_outer} tunnel IPV6 RX or TX packet number not correct",
                     )
                 else:
                     num = loading_size // 800
                     for i in range(num):
                         self.verify(
-                            payload_size_list[i] == 800,
+                            # i * packet_count + j is the i-th segmentation for j-th packet.
+                            all(
+                                [
+                                    payload_size_list[i * packet_count + j] == 800
+                                    for j in range(packet_count)
+                                ]
+                            ),
                             "the packet segmentation incorrect, %s" % payload_size_list,
                         )
                     if loading_size % 800 != 0:
                         self.verify(
-                            payload_size_list[num] == loading_size % 800,
+                            # num * packet_count + j is the last segmentation for j-th packet.
+                            all(
+                                [
+                                    payload_size_list[num * packet_count + j]
+                                    == loading_size % 800
+                                    for j in range(packet_count)
+                                ]
+                            ),
                             "the packet segmentation incorrect, %s" % payload_size_list,
                         )
 
-- 
2.25.1


  parent reply	other threads:[~2023-01-04  7:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04  7:20 [DTS][PATCH V3 0/3] add packets count, super-long packets and random payload to the case Ke Xu
2023-01-04  7:20 ` [DTS][PATCH V3 1/3] test_plans/vf_offload: fix wrong example packets Ke Xu
2023-01-04  7:20 ` [DTS][PATCH V3 2/3] test_plans/vf_offload: add packets count, super-long packets and random payload to the case Ke Xu
2023-01-04  7:20 ` Ke Xu [this message]
2023-01-05  7:11   ` [DTS][PATCH V3 3/3] tests/vf_offload: implement packets count, super-long packet and random payload Peng, Yuan
2023-01-05 14:26   ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104072053.86366-4-ke1.xu@intel.com \
    --to=ke1.xu@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    --cc=yuan.peng@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).