test suite reviews and discussions
 help / color / mirror / Atom feed
From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts][PATCH V1] tests/vf_vlan:modify code to adapt avx2 and avx512 on vlan offload
Date: Fri,  6 Jan 2023 18:09:21 +0000	[thread overview]
Message-ID: <20230106180921.354155-1-zhiminx.huang@intel.com> (raw)

add parameter "--enable-hw-vlan" in testpmd.
the dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35 fixed avx2 not support this parameter.
the avx2 behavior is not appropriate,it has gap between avx2 and avx512.
so we add parameter "enable-hw-vlan" in testpmd,there is no gap in avx2 and avx512 to test vlan strip.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
 test_plans/vf_vlan_test_plan.rst | 5 +++++
 tests/TestSuite_vf_vlan.py       | 3 ++-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/test_plans/vf_vlan_test_plan.rst b/test_plans/vf_vlan_test_plan.rst
index 24877c6c..8612bd84 100644
--- a/test_plans/vf_vlan_test_plan.rst
+++ b/test_plans/vf_vlan_test_plan.rst
@@ -186,6 +186,11 @@ Test case4: VF tagged vlan rx
 Test case5: VF Vlan strip test
 ==============================
 
+.. note::
+   according to dpdk commit 5cbfb386aa3f4c49b3cd9579e4e928cc5ab08d35,if not add parameter "enable-hw-vlan", the vlan
+   offload should be disable.the avx2 behavior is not appropriate, the avx2 and avx512 shouldn't have gap on vlan
+   offload. so add parameter "--enable-hw-vlan" in testpmd to test vlan strip.
+
 1. Start testpmd with mac forward mode::
 
      testpmd> set fwd mac
diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py
index d5a29c04..14c675c7 100644
--- a/tests/TestSuite_vf_vlan.py
+++ b/tests/TestSuite_vf_vlan.py
@@ -423,7 +423,8 @@ class TestVfVlan(TestCase):
         self.vm0_dut_ports = self.vm_dut_0.get_ports("any")
 
         self.vm0_testpmd = PmdOutput(self.vm_dut_0)
-        self.launch_testpmd(dcf_flag=self.dcf_mode)
+        param = "--enable-hw-vlan" if not self.dcf_mode else ""
+        self.launch_testpmd(dcf_flag=self.dcf_mode, param=param)
         self.vm0_testpmd.execute_cmd("set fwd rxonly")
         self.vm0_testpmd.execute_cmd("set verbose 1")
         self.vm0_testpmd.execute_cmd("start")
-- 
2.25.1


             reply	other threads:[~2023-01-06  9:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-06 18:09 Zhimin Huang [this message]
2023-01-09  3:28 ` Li, WeiyuanX
2023-01-10  7:56 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230106180921.354155-1-zhiminx.huang@intel.com \
    --to=zhiminx.huang@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).