test suite reviews and discussions
 help / color / mirror / Atom feed
From: Song Jiale <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Song Jiale <songx.jiale@intel.com>
Subject: [dts] [PATCH V1] tests/shutdown_api: modify the command to adapt to the changes in ethtool
Date: Mon, 16 Jan 2023 15:00:02 +0000	[thread overview]
Message-ID: <20230116150002.1789209-1-songx.jiale@intel.com> (raw)

The ethtool after version 5.4 does not support changing the network card speed 
when automatic negotiation is turned off. therefore, rm 'autoneg off' in script.


Signed-off-by: Song Jiale <songx.jiale@intel.com>
---
 tests/TestSuite_shutdown_api.py | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/tests/TestSuite_shutdown_api.py b/tests/TestSuite_shutdown_api.py
index fc81c46a..9cd2b273 100644
--- a/tests/TestSuite_shutdown_api.py
+++ b/tests/TestSuite_shutdown_api.py
@@ -320,11 +320,6 @@ class TestShutdownApi(TestCase):
             self.dut.destroy_sriov_vfs_by_port(self.used_dut_port)
             self.used_dut_port = None
 
-        for port in self.ports:
-            self.dut.send_expect(
-                "ethtool -s %s autoneg on " % self.dut.ports_info[port]["intf"], "#"
-            )
-
         self.bind_nic_driver(self.dut_ports, driver=self.used_driver or self.drivername)
 
         if not self.vm_env_done:
@@ -629,7 +624,7 @@ class TestShutdownApi(TestCase):
             for port in self.ports:
                 if len(configs) != 1:
                     self.dut.send_expect(
-                        "ethtool -s %s autoneg off  speed %s duplex %s"
+                        "ethtool -s %s speed %s duplex %s"
                         % (
                             self.dut.ports_info[port]["intf"],
                             config[0],
-- 
2.25.1


             reply	other threads:[~2023-01-16  7:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 15:00 Song Jiale [this message]
2023-01-29  2:27 ` Tu, Lijuan
2023-03-07  6:22 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230116150002.1789209-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).