test suite reviews and discussions
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: dts@dpdk.org, Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH] tests/dual_vlan: Explicitly wait for tcpdump
Date: Fri, 14 Apr 2023 21:47:39 +0900	[thread overview]
Message-ID: <20230414124739.67152-1-akihiko.odaki@daynix.com> (raw)

It is observed that sometimes tcpdump do not finish writing the packet
dump immediately after killed. Wait for tcpdump to avoid such race.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 tests/TestSuite_dual_vlan.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_dual_vlan.py b/tests/TestSuite_dual_vlan.py
index 70395663..694d4b2e 100644
--- a/tests/TestSuite_dual_vlan.py
+++ b/tests/TestSuite_dual_vlan.py
@@ -197,7 +197,7 @@ class TestDualVlan(TestCase):
 
     def get_tcpdump_package(self):
         self.tester.send_expect("killall tcpdump", "#")
-        self.tester.send_expect(" ", "#")
+        self.tester.send_expect("wait", "#")
         return self.tester.send_expect(
             "tcpdump -nn -e -v -r ./getPackageByTcpdump.cap", "#"
         )
-- 
2.40.0


             reply	other threads:[~2023-04-14 12:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 12:47 Akihiko Odaki [this message]
2023-04-23  8:55 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414124739.67152-1-akihiko.odaki@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).