test suite reviews and discussions
 help / color / mirror / Atom feed
From: Dukai Yuan <dukaix.yuan@intel.com>
To: dts@dpdk.org
Cc: Dukai Yuan <dukaix.yuan@intel.com>
Subject: [dts][PATCH V3] tests/vhost_async_robust_cbdma: Optimize calling virtio_common API method
Date: Thu, 27 Apr 2023 14:03:58 +0800	[thread overview]
Message-ID: <20230427060358.6817-1-dukaix.yuan@intel.com> (raw)

The tests/virtio_common.py have been optimized, so modify this suite
which calls the virtio_common API in cbdma_common() class.

Signed-off-by: Dukai Yuan <dukaix.yuan@intel.com>
---
 tests/TestSuite_vhost_async_robust_cbdma.py | 32 ++++++++++-----------
 1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/tests/TestSuite_vhost_async_robust_cbdma.py b/tests/TestSuite_vhost_async_robust_cbdma.py
index fda7cdfe..ea397a96 100644
--- a/tests/TestSuite_vhost_async_robust_cbdma.py
+++ b/tests/TestSuite_vhost_async_robust_cbdma.py
@@ -58,7 +58,7 @@ class TestVhostAsyncRobustCbdma(TestCase):
         self.dut.send_expect("rm -rf ./vhost-net*", "#")
         self.dut.send_expect("killall -s INT %s" % self.testpmd_name, "#")
         self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
-        self.CC.bind_all_cbdma_to_kernel()
+        self.CC.bind_cbdma_to_kernel_driver()
 
     @property
     def check_2M_env(self):
@@ -359,8 +359,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 1: PVP virtio-user quit test
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=1, driver_name="vfio-pci", socket=self.ports_socket
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=1, driver_name="vfio-pci", socket=self.ports_socket
         )
         dmas = "txq0@%s;rxq0@%s" % (cdbmas[0], cdbmas[0])
         vhost_eal_param = (
@@ -397,8 +397,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 2: PVP vhost-user quit test
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=1, driver_name="vfio-pci", socket=self.ports_socket
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=1, driver_name="vfio-pci", socket=self.ports_socket
         )
         dmas = "txq0@%s;rxq0@%s" % (cdbmas[0], cdbmas[0])
         vhost_eal_param = (
@@ -437,8 +437,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 3: PVP vhost async test with redundant device parameters
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=4, driver_name="vfio-pci", socket=self.ports_socket
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=4, driver_name="vfio-pci", socket=self.ports_socket
         )
         dmas = "txq0@%s;rxq0@%s" % (cdbmas[1], cdbmas[1])
         vhost_eal_param = (
@@ -472,8 +472,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 4: Loopback vhost async test with each queue using 2 DMA devices
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=3, driver_name="vfio-pci", socket=self.ports_socket
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=3, driver_name="vfio-pci", socket=self.ports_socket
         )
         dmas = "txq0@%s;txq0@%s;rxq0@%s;rxq0@%s" % (
             cdbmas[0],
@@ -510,8 +510,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 5: Loopback vhost async test with dmas parameters out of order
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=2, driver_name="vfio-pci", socket=self.ports_socket
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=2, driver_name="vfio-pci", socket=self.ports_socket
         )
         dmas = "rxq3@%s;txq0@%s;rxq1@%s;txq2@%s" % (
             cdbmas[1],
@@ -550,8 +550,8 @@ class TestVhostAsyncRobustCbdma(TestCase):
         """
         Test Case 6: VM2VM split and packed ring mergeable path with cbdma enable and server mode
         """
-        cdbmas = self.CC.bind_cbdma_to_dpdk(
-            cbdma_number=16, driver_name="vfio-pci", socket=-1
+        cdbmas = self.CC.bind_cbdma_to_dpdk_driver(
+            cbdma_num=16, driver_name="vfio-pci", socket=-1
         )
         dmas1 = (
             "txq0@%s;"
@@ -611,9 +611,9 @@ class TestVhostAsyncRobustCbdma(TestCase):
         )
 
         vhost_eal_param = (
-            "--vdev 'net_vhost0,iface=./vhost-net0,client=1,queues=8,dmas=[%s]' "
+            "--vdev 'net_vhost0,iface=./vhost-net0,client=1,queues=8,tso=1,dmas=[%s]' "
             % dmas1
-            + "--vdev 'net_vhost1,iface=./vhost-net1,client=1,queues=8,dmas=[%s]'"
+            + "--vdev 'net_vhost1,iface=./vhost-net1,client=1,queues=8,tso=1,dmas=[%s]'"
             % dmas2
         )
         vhost_param = "--nb-cores=4 --txq=8 --rxq=8 --txd=1024 --rxd=1024"
@@ -690,7 +690,7 @@ class TestVhostAsyncRobustCbdma(TestCase):
     def tear_down(self):
         self.dut.send_expect("killall -s INT %s" % self.testpmd_name, "#")
         self.dut.send_expect("killall -s INT qemu-system-x86_64", "#")
-        self.CC.bind_all_cbdma_to_kernel()
+        self.CC.bind_cbdma_to_kernel_driver()
 
     def tear_down_all(self):
         self.close_all_session()
-- 
2.17.1


             reply	other threads:[~2023-04-27  6:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27  6:03 Dukai Yuan [this message]
2023-04-27  9:59 ` Ling, WeiX
2023-04-28  0:40 ` lijuan.tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230427060358.6817-1-dukaix.yuan@intel.com \
    --to=dukaix.yuan@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).