From: Zhimin Huang <zhiminx.huang@intel.com>
To: dts@dpdk.org
Cc: Zhimin Huang <zhiminx.huang@intel.com>
Subject: [dts][PATCH V1] tests/ice_dcf_disable_acl_filter:optimize code for testpmd status flag
Date: Wed, 14 Jun 2023 18:03:52 +0000 [thread overview]
Message-ID: <20230614180352.1194502-1-zhiminx.huang@intel.com> (raw)
if the case validation failed,the testpmd_status will not be assigned value.
Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
tests/TestSuite_ice_dcf_disable_acl_filter.py | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/tests/TestSuite_ice_dcf_disable_acl_filter.py b/tests/TestSuite_ice_dcf_disable_acl_filter.py
index 7e12ad0e..937ba406 100644
--- a/tests/TestSuite_ice_dcf_disable_acl_filter.py
+++ b/tests/TestSuite_ice_dcf_disable_acl_filter.py
@@ -234,11 +234,11 @@ class TestICEDCFDisableACLFilter(TestCase):
# get the average
avg_start_up_time_acl_on = sum(start_up_time_acl_on) / repeat_time
avg_start_up_time_acl_off = sum(start_up_time_acl_off) / repeat_time
+ self.testpmd_status = "close"
self.verify(
avg_start_up_time_acl_on > avg_start_up_time_acl_off,
"disable acl to reduce startup time failed!!!",
)
- self.testpmd_status = "close"
def test_disable_acl(self):
"""
@@ -267,9 +267,8 @@ class TestICEDCFDisableACLFilter(TestCase):
self.logger.warning((RED(e)))
self.logger.info((GREEN("case failed: %s" % subcase["name"])))
subcases["result"].append(False)
- self.verify(all(subcases["result"]), "test disable acl engine failed.")
-
self.testpmd_status = "open"
+ self.verify(all(subcases["result"]), "test disable acl engine failed.")
def quit_testpmd(self):
"""
--
2.25.1
reply other threads:[~2023-06-14 9:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230614180352.1194502-1-zhiminx.huang@intel.com \
--to=zhiminx.huang@intel.com \
--cc=dts@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).