test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: dts@dpdk.org
Cc: oss-drivers@corigine.com, "Qin Ke" <qin.ke@corigine.com>,
	"Dano Teixeira" <dano.teixeira@corigine.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>
Subject: [PATCH] tests/firmware_version: add case of nfp driver
Date: Mon,  3 Jul 2023 21:16:29 +0200	[thread overview]
Message-ID: <20230703191629.31297-1-niklas.soderlund@corigine.com> (raw)

From: Qin Ke <qin.ke@corigine.com>

Add case of nfp driver to check related firmware version and format.

Signed-off-by: Qin Ke <qin.ke@corigine.com>
Acked-by: Dano Teixeira <dano.teixeira@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 tests/TestSuite_firmware_version.py | 44 +++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/tests/TestSuite_firmware_version.py b/tests/TestSuite_firmware_version.py
index a5215c40441b..0e26b519ed19 100644
--- a/tests/TestSuite_firmware_version.py
+++ b/tests/TestSuite_firmware_version.py
@@ -140,6 +140,50 @@ class TestFirmwareVersion(TestCase):
                     None,
                 )
 
+            elif self.kdriver == "nfp":
+                # Get the version information from output and cfg file
+                (
+                    exp_vnic_version,
+                    exp_nsp_version,
+                    exp_mip,
+                    exp_app,
+                ) = expected_version_info
+                vnic_version, nsp_version, mip, app = version_info.split()
+
+                self.check_format(
+                    exp_nsp_version,
+                    nsp_version,
+                    "nsp_version",
+                    r"^\d{1,4}\.\d{1,4}$",
+                    None,
+                )
+
+                self.check_firmware_version(exp_nsp_version, nsp_version)
+
+                self.check_format(
+                    exp_vnic_version,
+                    vnic_version,
+                    "vnic_version",
+                    r"^((\d{1,4}\.\d{1,4}\.\d{1,4}\.\d{1,4})|\*)$",
+                    None,
+                )
+
+                self.check_format(
+                    exp_mip,
+                    mip,
+                    "mip",
+                    r"^(tc|sriov|nic)-.*$",
+                    None,
+                )
+
+                self.check_format(
+                    exp_app,
+                    app,
+                    "app",
+                    r"(flower|nic|unknown)",
+                    None,
+                )
+
             else:
                 self.verify(False, f"Test: case fails on {self.kdriver} driver")
 
-- 
2.41.0


             reply	other threads:[~2023-07-03 19:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-03 19:16 Niklas Söderlund [this message]
2023-08-11 11:15 ` Niklas Söderlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230703191629.31297-1-niklas.soderlund@corigine.com \
    --to=niklas.soderlund@corigine.com \
    --cc=dano.teixeira@corigine.com \
    --cc=dts@dpdk.org \
    --cc=oss-drivers@corigine.com \
    --cc=qin.ke@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).