test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@corigine.com>
To: dts@dpdk.org
Cc: oss-drivers@corigine.com, "Qin Ke" <qin.ke@corigine.com>,
	"Niklas Söderlund" <niklas.soderlund@corigine.com>
Subject: [PATCH] nics/net_device: add longer timeout for binding driver
Date: Fri, 11 Aug 2023 15:09:19 +0200	[thread overview]
Message-ID: <20230811130919.3213476-1-niklas.soderlund@corigine.com> (raw)

From: Qin Ke <qin.ke@corigine.com>

It may take a long time whiling binding NIC port to specified
driver, add longer timeout to ensure this operation can execute
successfully and stably for all NIC.

It is required for NFP as it can take a long time to bind

Signed-off-by: Qin Ke <qin.ke@corigine.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>
---
 nics/net_device.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/nics/net_device.py b/nics/net_device.py
index 0f9c1af46a77..ec75d017df50 100644
--- a/nics/net_device.py
+++ b/nics/net_device.py
@@ -832,7 +832,9 @@ class NetDevice(object):
             "# ",
         )
         self.__send_expect(
-            "echo %s > /sys/bus/pci/drivers/%s/bind" % (nic_pci_num, driver), "# "
+            "echo %s > /sys/bus/pci/drivers/%s/bind" % (nic_pci_num, driver),
+            "# ",
+            timeout=80,
         )
         if driver == self.default_driver:
             itf = self.get_interface_name()
-- 
2.41.0


                 reply	other threads:[~2023-08-11 13:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230811130919.3213476-1-niklas.soderlund@corigine.com \
    --to=niklas.soderlund@corigine.com \
    --cc=dts@dpdk.org \
    --cc=oss-drivers@corigine.com \
    --cc=qin.ke@corigine.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).