test suite reviews and discussions
 help / color / mirror / Atom feed
From: Jiale Song <songx.jiale@intel.com>
To: dts@dpdk.org
Cc: Jiale Song <songx.jiale@intel.com>
Subject: [dts] [PATCH V2] tests/ice_dcf_qos: optimize scripts
Date: Mon, 14 Aug 2023 23:18:36 +0800	[thread overview]
Message-ID: <20230814151836.1494836-1-songx.jiale@intel.com> (raw)

optimize scripts:
    1. modify pf reset method.
    2. modify incorrect inspection ports and detection values according
to the testing plan.
    3. Modify the detection rate from 25Gbps to 45Gbps. this value is the
actual measured value.

Signed-off-by: Jiale Song <songx.jiale@intel.com>
---
 test_plans/ice_dcf_qos_test_plan.rst |  2 +-
 tests/TestSuite_ice_dcf_qos.py       | 13 +++++--------
 2 files changed, 6 insertions(+), 9 deletions(-)

diff --git a/test_plans/ice_dcf_qos_test_plan.rst b/test_plans/ice_dcf_qos_test_plan.rst
index b2cb08ce..ab3d6035 100644
--- a/test_plans/ice_dcf_qos_test_plan.rst
+++ b/test_plans/ice_dcf_qos_test_plan.rst
@@ -1238,7 +1238,7 @@ This case is to check if the QoS setting works after resetting PF.
 
 2. Reset pf::
 
-    echo 1 > /sys/devices/pci0000:17/0000:17:00.0/0000:18:00.0/reset
+    echo 1 > /sys/bus/pci/devices/0000:31:00.0/reset
 
 3. Send same streams as step1, check no packets received and transmitted.
 
diff --git a/tests/TestSuite_ice_dcf_qos.py b/tests/TestSuite_ice_dcf_qos.py
index bd0317db..ff4409d0 100644
--- a/tests/TestSuite_ice_dcf_qos.py
+++ b/tests/TestSuite_ice_dcf_qos.py
@@ -908,7 +908,7 @@ class TestICEDCFQos(TestCase):
             [[5], 12.5, (8, "Gbps", 3)],
             [[6], 12.5, (8, "Gbps", 3)],
             [[7], 12.5, (8, "Gbps", 3)],
-            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (9.7, "Gbps", 1)],
+            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (9.77, "Gbps", 3)],
         ]
         results = self.check_traffic(stream_configs, traffic_tasks, frame_size=1024)
         queue_mapping = [
@@ -928,7 +928,7 @@ class TestICEDCFQos(TestCase):
         ]
         time.sleep(10)
         traffic_tasks = [
-            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (7.273, "Gbps", 1)],
+            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (7.273, "Gbps", 3)],
         ]
         results = self.check_traffic(stream_configs, traffic_tasks, frame_size=68)
         self.testpmd_close()
@@ -1017,7 +1017,7 @@ class TestICEDCFQos(TestCase):
             [[5], 12.5, (2, "MBps", 2)],
             [[6], 12.5, (2, "MBps", 2)],
             [[7], 12.5, (4, "MBps", 2)],
-            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (12.5, "Gbps")],
+            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (128, "Mbps")],
         ]
         results = self.check_traffic(stream_configs, traffic_tasks)
         self.testpmd_close()
@@ -1446,7 +1446,7 @@ class TestICEDCFQos(TestCase):
         ]
         self.pmd_con(cmds)
         traffic_tasks = [
-            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (25, "Gbps")],
+            [[0, 1, 2, 3, 4, 5, 6, 7], 100, (45, "Gbps")],
         ]
         results = self.check_traffic(stream_configs, traffic_tasks, frame_size=68)
         self.pmd_con("stop")
@@ -1847,10 +1847,7 @@ class TestICEDCFQos(TestCase):
         ]
         results = self.check_traffic(stream_configs, traffic_tasks)
         self.testpmd_close()
-        pci = str(int(self.nic100g_pci[5:7]) - 1)
-        cmds = [
-            f"echo 1 > /sys/devices/pci0000:{pci}/0000:{pci}:00.0/{self.nic100g_pci}/reset",
-        ]
+        cmds = ["echo 1 > /sys/bus/pci/devices/%s/reset" % self.nic100g_pci]
         self.d_a_con(cmds)
         self.strict_mode_check_peak_tb_rate_preset(vfs_grp, commit_check=False)
         stream_configs = [
-- 
2.25.1


                 reply	other threads:[~2023-08-14  7:08 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230814151836.1494836-1-songx.jiale@intel.com \
    --to=songx.jiale@intel.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).