test suite reviews and discussions
 help / color / mirror / Atom feed
From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: dts@dpdk.org
Cc: Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH] framework/crb: Do not use egrep
Date: Sat, 03 Feb 2024 19:27:58 +0900	[thread overview]
Message-ID: <20240203-crb-v1-1-cdebc1922634@daynix.com> (raw)

GNU grep 3.8 outputs:
> egrep: warning: egrep is obsolescent; using grep -E

This makes self.send_expect() fail.

Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
 framework/crb.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/framework/crb.py b/framework/crb.py
index 9e3b0a58..9b7688c7 100644
--- a/framework/crb.py
+++ b/framework/crb.py
@@ -1069,7 +1069,7 @@ class Crb(object):
         elif self.get_os_type() == "freebsd":
             return False
         elif self.send_expect(
-            "systemd-detect-virt -c|egrep '(systemd-nspawn|lxc|docker|podman|rkt|wsl|container-other)$' ",
+            "systemd-detect-virt -c|grep -E '(systemd-nspawn|lxc|docker|podman|rkt|wsl|container-other)$' ",
             "# ",
         ):
             return True

---
base-commit: 427e7c3f37bbb1263d81c466d7a83e9193013321
change-id: 20240203-crb-131f32522af5

Best regards,
-- 
Akihiko Odaki <akihiko.odaki@daynix.com>


                 reply	other threads:[~2024-02-03 10:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240203-crb-v1-1-cdebc1922634@daynix.com \
    --to=akihiko.odaki@daynix.com \
    --cc=dts@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).