test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
	"ohilyard@iol.unh.edu" <ohilyard@iol.unh.edu>,
	"Chen, Zhaoyan" <zhaoyan.chen@intel.com>,
	"Dong, JunX" <junx.dong@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH v5] python: standard project structure
Date: Fri, 22 Oct 2021 08:28:05 +0000	[thread overview]
Message-ID: <20b9cd0d521345769491803a62e921ab@intel.com> (raw)
In-Reply-To: <1634647890-15498-1-git-send-email-juraj.linkes@pantheon.tech>

> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: 2021年10月19日 20:52
> To: Tu, Lijuan <lijuan.tu@intel.com>; ohilyard@iol.unh.edu; Chen, Zhaoyan
> <zhaoyan.chen@intel.com>; Dong, JunX <junx.dong@intel.com>
> Cc: dts@dpdk.org; Juraj Linkeš <juraj.linkes@pantheon.tech>
> Subject: [PATCH v5] python: standard project structure
> 
> DTS does not use the standard project structure and therefore has to add
> paths to python interpreter search paths. Move to a standard structure:
> * Move main.py to the root directory.
> * Add __init__.py to directories from which python modules are imported.
> * Adjust import paths to account for this new structure.
> 
> Moving to a standard structure has a host of positives, such as:
> * No need to study any non-standard approaches. This removes any
> bewilderment the developers may feel when encountering something
> non-standard without proper justification (as is the case with DTS).
> * Better integration with IDEs which rely on the standard structure.
> * More accurate results from automated tools.
> 
> In addition to this, not only adjust the import paths but make then
> explicit for modules imported from the same level, e.g. instead of using
> from foo import, use from .foo import (and import bar.foo as foo, where
> foo if on the same level as the importing module). This allows
> developers to separate DTS modules from third party modules at a glance.
> 
> Also sort the import using the isort tool. Add config using the "black"
> profile for isort to facilitate interoperability with Black.
> 
> Signed-off-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Applied, thanks

      reply	other threads:[~2021-10-22  8:28 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 11:34 [dts] [PATCH v1] " Juraj Linkeš
2021-08-24 13:46 ` Owen Hilyard
2021-08-27  9:19   ` Juraj Linkeš
2021-08-27 13:03 ` [dts] [PATCH v2] " Juraj Linkeš
2021-09-06  3:01   ` Tu, Lijuan
2021-09-09 11:05     ` Juraj Linkeš
2021-09-10 12:31       ` Juraj Linkeš
2021-09-10 13:41   ` [dts] [PATCH v3] " Juraj Linkeš
2021-09-16  2:33     ` Tu, Lijuan
2021-10-07 11:26     ` [dts] [PATCH v4] " Juraj Linkeš
2021-10-19 12:51       ` [dts] [PATCH v5] " Juraj Linkeš
2021-10-22  8:28         ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20b9cd0d521345769491803a62e921ab@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=junx.dong@intel.com \
    --cc=juraj.linkes@pantheon.tech \
    --cc=ohilyard@iol.unh.edu \
    --cc=zhaoyan.chen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).