Re: [dts] [PATCH V2] Modify the clv offset code

["Peng, ZhihongX" <zhihongx.peng@intel.com>]

https://jira.devtools.intel.com/browse/DPDK-16219 
Wang, Ying A gave me the wrong advice. She asked me to follow my test

-----Original Message-----
From: Peng, ZhihongX 
Sent: Tuesday, October 22, 2019 5:56 PM
To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org
Subject: RE: [dts] [PATCH V2] Modify the clv offset code

My test results show that packets can be received up to 8 bytes above the maximum mtu and can be forwarded normally.

-----Original Message-----
From: Tu, Lijuan 
Sent: Tuesday, October 22, 2019 5:51 PM
To: Peng, ZhihongX <zhihongx.peng@intel.com>; dts@dpdk.org
Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
Subject: RE: [dts] [PATCH V2] Modify the clv offset code

I can't understand why is the patch, thanks

Columbiaville and Fortville has the same overhead length, so why they are in different catalogs.
#define ICE_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + ICE_VLAN_TAG_SIZE * 2)

#define I40E_ETH_OVERHEAD \
        (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN + I40E_VLAN_TAG_SIZE * 2)


> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Peng Zhihong
> Sent: Monday, October 21, 2019 7:22 PM
> To: dts@dpdk.org
> Cc: Peng, ZhihongX <zhihongx.peng@intel.com>
> Subject: [dts] [PATCH V2] Modify the clv offset code
> 
> Signed-off-by: Peng Zhihong <zhihongx.peng@intel.com>
> ---
>  tests/TestSuite_userspace_ethtool.py | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/TestSuite_userspace_ethtool.py
> b/tests/TestSuite_userspace_ethtool.py
> index 116fd3a..94918e9 100644
> --- a/tests/TestSuite_userspace_ethtool.py
> +++ b/tests/TestSuite_userspace_ethtool.py
> @@ -546,9 +546,16 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>          mtus = [1519, 2048]
>          mtu_threshold = 2022
>          offset = 0
> +
>          if self.nic in ['powerville', 'springville']:
>              mtu_threshold = 2026
>              offset = 4
> +        elif self.nic in ['columbiaville_25g', 'columbiaville_100g']:
> +            #ICE_ETH_OVERHEAD is 8
> +            offset = 8
> +        else:
> +            pass
> +
>          for index in range(len(self.ports)):
>              port = self.ports[index]
>              # change mtu
> @@ -561,10 +568,9 @@ class TestUserspaceEthtool(TestCase,
> IxiaPacketGenerator):
>                  if mtu > mtu_threshold:
>                      if self.nic in ['powerville', 'springville']:
>                          mtu = mtu_threshold
> -                    self.dut.send_expect("stop %s" % index, "EthApp>")
> -                    self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> -                    self.dut.send_expect("open %s" % index, "EthApp>")
> +                self.dut.send_expect("stop %s" % index, "EthApp>")
>                  self.dut.send_expect("mtu %d %d" % (index, mtu), "EthApp>")
> +                self.dut.send_expect("open %s" % index, "EthApp>")
>                  time.sleep(5)
>                  ori_rx_pkts, _ = self.strip_portstats(index)
>                  pkt_size = mtu + HEADER_SIZE['eth'] + offset
> --
> 2.17.1