test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH V1] tests/ipgre: optimize script
@ 2019-09-06 18:42 Wenjie Li
  2019-09-09  2:36 ` Zhang, YanX A
  2019-09-18 10:34 ` Tu, Lijuan
  0 siblings, 2 replies; 3+ messages in thread
From: Wenjie Li @ 2019-09-06 18:42 UTC (permalink / raw)
  To: dts; +Cc: Wenjie Li

1. could support cvl nic, add cvl to nic list
2. move dut.kill_all from tear_down_all to tear_down, since testpmd will
be started in every case, if one case is failed, the testpmd is still
runnning, this will affect the following cases.

Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
---
 tests/TestSuite_ipgre.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tests/TestSuite_ipgre.py b/tests/TestSuite_ipgre.py
index 7fbddf1..e10b0e0 100644
--- a/tests/TestSuite_ipgre.py
+++ b/tests/TestSuite_ipgre.py
@@ -63,7 +63,7 @@ class TestIpgre(TestCase):
         """
         self.printFlag = self._enable_debug
         ports = self.dut.get_ports()
-        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville"],
+        self.verify(self.nic in ["fortville_eagle", "fortville_spirit", "fortville_spirit_single", "fortville_25g", "carlsville", "columbiaville_25g", "columbiaville_100g"],
                     "GRE tunnel packet type only support by fortville and carlsville")
         self.verify(len(ports) >= 1, "Insufficient ports for testing")
         valports = [_ for _ in ports if self.tester.get_local_port(_) != -1]
@@ -439,12 +439,11 @@ class TestIpgre(TestCase):
         Run after each test case.
         Nothing to do.
         """
-        pass
+        self.dut.kill_all()
 
     def tear_down_all(self):
         """
         Run after each test suite.
         Nothing to do.
         """
-        self.dut.kill_all()
         pass
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-09-18 10:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-06 18:42 [dts] [PATCH V1] tests/ipgre: optimize script Wenjie Li
2019-09-09  2:36 ` Zhang, YanX A
2019-09-18 10:34 ` Tu, Lijuan

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).