Re: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file uncomplete during scp file from host to VM

["Yao, Lei A" <lei.a.yao@intel.com>]

Hi, Yong

See my comments. Thanks.

> -----Original Message-----
> From: Liu, Yong
> Sent: Monday, December 19, 2016 10:50 AM
> To: Yao, Lei A <lei.a.yao@intel.com>; dts@dpdk.org
> Cc: Yao, Lei A <lei.a.yao@intel.com>
> Subject: RE: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid
> file uncomplete during scp file from host to VM
> 
> Hi Lei,
> One question for why added the dealy.
> 
> > -----Original Message-----
> > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yao Lei
> > Sent: Friday, December 16, 2016 2:54 PM
> > To: dts@dpdk.org
> > Cc: Yao, Lei A
> > Subject: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid
> file
> > uncomplete during scp file from host to VM
> >
> > From: lei yao <lei.a.yao@intel.com>
> >
> > Signed-off-by: lei yao <lei.a.yao@intel.com>
> > ---
> >  framework/ssh_pexpect.py | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> > index d5b6616..09095a1 100644
> > --- a/framework/ssh_pexpect.py
> > +++ b/framework/ssh_pexpect.py
> > @@ -185,6 +185,7 @@ class SSHPexpect(object):
> >          if i == 1:
> >              time.sleep(0.5)
> >              p.sendline(password)
> > +            time.sleep(10)
> >              p.expect("100%", 60)
> Expect function has been already wait for about one minute, look like there's
> no need to add more time.
This timeout is used before sending the ssh cmd. Not waiting time. During virtualization test, we find the file will always be corrupted when scp dpdk.tar.gz from host to vm. Wait 10s after ssh connection set up , then send scp cmd will resolve this failure. 
> 
> >          if i == 4:
> >              self.logger.error("SCP TIMEOUT error %d" % i)
> > --
> > 2.7.4