From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 5677736E for ; Mon, 19 Dec 2016 04:15:53 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP; 18 Dec 2016 19:15:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,372,1477983600"; d="scan'208";a="43973988" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 18 Dec 2016 19:15:51 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 19:15:51 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 19:15:51 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.54]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.235]) with mapi id 14.03.0248.002; Mon, 19 Dec 2016 11:15:48 +0800 From: "Yao, Lei A" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file uncomplete during scp file from host to VM Thread-Index: AQHSWaKk2vFBVfcJFUW0Kcvq+eLsN6EOmFsQ Date: Mon, 19 Dec 2016 03:15:48 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A134F28@shsmsx102.ccr.corp.intel.com> References: <1481871227-4334-1-git-send-email-lei.a.yao@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A457@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A457@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file uncomplete during scp file from host to VM X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 03:15:53 -0000 Hi, Yong See my comments. Thanks. > -----Original Message----- > From: Liu, Yong > Sent: Monday, December 19, 2016 10:50 AM > To: Yao, Lei A ; dts@dpdk.org > Cc: Yao, Lei A > Subject: RE: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid > file uncomplete during scp file from host to VM >=20 > Hi Lei, > One question for why added the dealy. >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yao Lei > > Sent: Friday, December 16, 2016 2:54 PM > > To: dts@dpdk.org > > Cc: Yao, Lei A > > Subject: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid > file > > uncomplete during scp file from host to VM > > > > From: lei yao > > > > Signed-off-by: lei yao > > --- > > framework/ssh_pexpect.py | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py > > index d5b6616..09095a1 100644 > > --- a/framework/ssh_pexpect.py > > +++ b/framework/ssh_pexpect.py > > @@ -185,6 +185,7 @@ class SSHPexpect(object): > > if i =3D=3D 1: > > time.sleep(0.5) > > p.sendline(password) > > + time.sleep(10) > > p.expect("100%", 60) > Expect function has been already wait for about one minute, look like the= re's > no need to add more time. This timeout is used before sending the ssh cmd. Not waiting time. During v= irtualization test, we find the file will always be corrupted when scp dpdk= .tar.gz from host to vm. Wait 10s after ssh connection set up , then send s= cp cmd will resolve this failure.=20 >=20 > > if i =3D=3D 4: > > self.logger.error("SCP TIMEOUT error %d" % i) > > -- > > 2.7.4