From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 17F6E36E for ; Mon, 19 Dec 2016 04:20:00 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP; 18 Dec 2016 19:19:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,372,1477983600"; d="scan'208";a="1073792587" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 18 Dec 2016 19:19:59 -0800 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 19:19:59 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 18 Dec 2016 19:19:59 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.54]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.11]) with mapi id 14.03.0248.002; Mon, 19 Dec 2016 11:19:57 +0800 From: "Yao, Lei A" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and "multi_queue" parameter for more qemu launch option and adjust some timeout setting to improve the test stability Thread-Index: AQHSWaPv28EROBSphUKgUrUVzsD3JqEOmV8g Date: Mon, 19 Dec 2016 03:19:56 +0000 Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A135F42@shsmsx102.ccr.corp.intel.com> References: <1481874899-4510-1-git-send-email-lei.a.yao@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A500@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A500@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and "multi_queue" parameter for more qemu launch option and adjust some timeout setting to improve the test stability X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 03:20:01 -0000 Hi, Yong Only part test cases will use this parameter, so I don't want add it to the= .cfg file but keep them in the tests file. Then I can use common .cfg file= to different vhost/virtio test cases.=20 For the comment, I can add most info in the commit log in the V2 patch. Tha= nks BRs Lei > -----Original Message----- > From: Liu, Yong > Sent: Monday, December 19, 2016 11:00 AM > To: Yao, Lei A ; dts@dpdk.org > Cc: Yao, Lei A > Subject: RE: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and > "multi_queue" parameter for more qemu launch option and adjust some > timeout setting to improve the test stability >=20 > Hi Lei, > Both "server" and "multi_queue" are new parameters for qemu hypervisor > library. > You'd better add some reference in configuration file like sriov_kvm.cfg. >=20 > Please also give some basic descriptions for these two parameters in comm= it > log. >=20 > Thanks, > Marvin >=20 > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Yao Lei > > Sent: Friday, December 16, 2016 3:55 PM > > To: dts@dpdk.org > > Cc: Yao, Lei A > > Subject: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and > > "multi_queue" parameter for more qemu launch option and adjust some > > timeout setting to improve the test stability > > > > From: lei yao > > > > Signed-off-by: lei yao > > --- > > framework/qemu_kvm.py | 24 +++++++++++++++++------- > > 1 file changed, 17 insertions(+), 7 deletions(-) > > > > diff --git a/framework/qemu_kvm.py b/framework/qemu_kvm.py > > index 6ced54a..e9d29cc 100644 > > --- a/framework/qemu_kvm.py > > +++ b/framework/qemu_kvm.py > > @@ -606,21 +606,31 @@ class QEMUKvm(VirtBase): > > if 'opt_path' in options.keys() and options['opt_path']: > > dev_boot_line =3D '-chardev socket' > > char_id =3D 'char%d' % self.char_idx > > - dev_boot_line +=3D separator + 'id=3D%s' % char_id + separ= ator + > > 'path=3D%s' % options['opt_path'] > > - self.char_idx +=3D 1 > > - self.__add_boot_line(dev_boot_line) > > + if 'opt_server' in options.keys() and options['opt_server'= ]: > > + dev_boot_line +=3D separator + 'id=3D%s' % char_id + > > separator + 'path=3D%s' %options['opt_path'] + separator + '%s' % > > options['opt_server'] > > + self.char_idx +=3D 1 > > + self.__add_boot_line(dev_boot_line) > > + else: > > + dev_boot_line +=3D separator + 'id=3D%s' % char_id + > > separator + 'path=3D%s' %options['opt_path'] > > + self.char_idx +=3D 1 > > + self.__add_boot_line(dev_boot_line) > > # netdev parameter > > netdev_id =3D 'netdev%d' % self.netdev_idx > > self.netdev_idx +=3D 1 > > - dev_boot_line =3D '-netdev type=3Dvhost- > > user,id=3D%s,chardev=3D%s,vhostforce' % (netdev_id, char_id) > > + if 'opt_queue' in options.keys() and options['opt_queue']: > > + queue_num=3Doptions['opt_queue'] > > + dev_boot_line =3D '-netdev type=3Dvhost- > > user,id=3D%s,chardev=3D%s,vhostforce,queues=3D%s' % (netdev_id, > > char_id,queue_num) > > + else: > > + dev_boot_line =3D '-netdev type=3Dvhost- > > user,id=3D%s,chardev=3D%s,vhostforce' % (netdev_id, char_id) > > self.__add_boot_line(dev_boot_line) > > # device parameter > > opts =3D {'opt_netdev': '%s' % netdev_id} > > if 'opt_mac' in options.keys() and \ > > options['opt_mac']: > > opts['opt_mac'] =3D options['opt_mac'] > > - > > - self.__add_vm_virtio_net_pci(**opts) > > + if 'opt_settings' in options.keys() and > > options['opt_settings']: > > + opts['opt_settings'] =3D options['opt_settings'] > > + self.__add_vm_virtio_net_pci(**opts) > > > > def __add_vm_virtio_cuse_pci(self, **options): > > """ > > @@ -939,7 +949,7 @@ class QEMUKvm(VirtBase): > > wait for 120 seconds for vm net ready > > 10.0.2.* is the default ip address allocated by qemu > > """ > > - count =3D 20 > > + count =3D 40 > > while count: > > out =3D self.__control_session('ifconfig') > > if "10.0.2" in out: > > -- > > 2.7.4