Re: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid file uncomplete during scp file from host to VM

["Yao, Lei A" <lei.a.yao@intel.com>]

> -----Original Message-----
> From: Liu, Yong
> Sent: Monday, December 19, 2016 11:25 AM
> To: Yao, Lei A <lei.a.yao@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] framework ssh_pexpect: add timeout to avoid
> file uncomplete during scp file from host to VM
> 
> > > > diff --git a/framework/ssh_pexpect.py b/framework/ssh_pexpect.py
> > > > index d5b6616..09095a1 100644
> > > > --- a/framework/ssh_pexpect.py
> > > > +++ b/framework/ssh_pexpect.py
> > > > @@ -185,6 +185,7 @@ class SSHPexpect(object):
> > > >          if i == 1:
> > > >              time.sleep(0.5)
> > > >              p.sendline(password)
> > > > +            time.sleep(10)
> > > >              p.expect("100%", 60)
> > > Expect function has been already wait for about one minute, look like
> > there's
> > > no need to add more time.
> > This timeout is used before sending the ssh cmd. Not waiting time. During
> > virtualization test, we find the file will always be corrupted when scp
> > dpdk.tar.gz from host to vm. Wait 10s after ssh connection set up , then
> > send scp cmd will resolve this failure.
> 
> The sleep command is after "password" message, so I think connection
> between VM and host machine has been created and worked.
> What I wonder is that why file is corrupted after "100%" hint. Either expect
> worked abnormally or some issues we haven't figured out.
> 
I can't find out the root cause at my side. This issue can't reproduced manually because human will always wait 2~3 seconds after ssh connection set up , then send scp cmd.  Also can't reproduced by pdb. This patch is just the practice experience which can avoid this error. 
> 
> Thanks,
> Marvin