test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Yao, Lei A" <lei.a.yao@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and	"multi_queue" parameter for more qemu launch option and	adjust some timeout setting to improve the test stability
Date: Mon, 19 Dec 2016 04:46:23 +0000	[thread overview]
Message-ID: <2DBBFF226F7CF64BAFCA79B681719D953A135FA5@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D1A5A7@SHSMSX103.ccr.corp.intel.com>

Understand. I will add more introduction into the vhost_sample.cfg in the V2 patch. Thanks.

BRs
Lei

> -----Original Message-----
> From: Liu, Yong
> Sent: Monday, December 19, 2016 11:33 AM
> To: Yao, Lei A <lei.a.yao@intel.com>; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and
> "multi_queue" parameter for more qemu launch option and adjust some
> timeout setting to improve the test stability
> 
> Lei, I known only few cases use these parameters. What I mean is that to add
> some comments for these parameters.
> There's one document doc/dts_gsg/virtualization.rst which is the reference
> for qemu configure parameters.
> But modified this doc need more effort, so which I recommend is that just
> add the comments in one configuration file which contain all parameters.
> It can help other users for understand how to use these parameters.
> 
> Thanks,
> Marvin
> 
> > -----Original Message-----
> > From: Yao, Lei A
> > Sent: Monday, December 19, 2016 11:20 AM
> > To: Liu, Yong; dts@dpdk.org
> > Subject: RE: [dts] [PATCH V1] framework qemu_kvm.py: Add "server" and
> > "multi_queue" parameter for more qemu launch option and adjust some
> > timeout setting to improve the test stability
> >
> > Hi, Yong
> >
> > Only part test cases will use this parameter, so I don't want add it to
> > the .cfg file but keep them in the tests file. Then I can use common .cfg
> > file to different vhost/virtio test cases.
> > For the comment, I can add most info in the commit log in the V2 patch.
> > Thanks
> >
> > BRs
> > Lei
> >
> > > -----Original Message-----
> > > From: Liu, Yong
> > > Sent: Monday, December 19, 2016 11:00 AM
> > > To: Yao, Lei A <lei.a.yao@intel.com>; dts@dpdk.org
> > > Cc: Yao, Lei A <lei.a.yao@intel.com>
> > > Subject: RE: [dts] [PATCH V1] framework qemu_kvm.py: Add "server"
> and
> > > "multi_queue" parameter for more qemu launch option and adjust some
> > > timeout setting to improve the test stability
> > >
> > > Hi Lei,
> > > Both "server" and "multi_queue" are new parameters for qemu
> hypervisor
> > > library.
> > > You'd better add some reference in configuration file like sriov_kvm.cfg.
> > >
> > > Please also give some basic descriptions for these two parameters in
> > commit
> > > log.
> > >
> > > Thanks,
> > > Marvin
> > >

      reply	other threads:[~2016-12-19  4:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-16  7:54 Yao Lei
2016-12-19  2:59 ` Liu, Yong
2016-12-19  3:19   ` Yao, Lei A
2016-12-19  3:33     ` Liu, Yong
2016-12-19  4:46       ` Yao, Lei A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2DBBFF226F7CF64BAFCA79B681719D953A135FA5@shsmsx102.ccr.corp.intel.com \
    --to=lei.a.yao@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).