test suite reviews and discussions
 help / color / mirror / Atom feed
From: Thinh Tran <thinhtr@linux.vnet.ibm.com>
To: "Mo, YufengX" <yufengx.mo@intel.com>
Cc: "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH v2] tests/unit_tests_timer increase timeout
Date: Mon, 22 Jul 2019 07:18:07 -0500	[thread overview]
Message-ID: <348089e1-3fe9-d8eb-c594-4e19fcda5a8b@linux.vnet.ibm.com> (raw)
In-Reply-To: <B8B15C44A3F2C044966E545C7B7371153E81B253@shsmsx102.ccr.corp.intel.com>

Sorry. v2 was on top off v1. will resend it shortly.

On 7/21/2019 9:01 PM, Mo, YufengX wrote:
> self.this_timeout is not defined. I think you haven't rebase your source code.
> 
> 
>> -----Original Message-----
>> From: Thinh Tran [mailto:thinhtr@linux.vnet.ibm.com]
>> Sent: Friday, July 19, 2019 9:00 PM
>> To: Mo, YufengX <yufengx.mo@intel.com>
>> Cc: dts@dpdk.org; thinhtr@linux.vnet.ibm.com
>> Subject: [dts][PATCH v2] tests/unit_tests_timer increase timeout
>>
>> Signed-off-by: Thinh Tran <thinhtr@linux.vnet.ibm.com>
>> ---
>>   changes v1 -> v2:
>>     - add missing self to this_timeout
>>
>>   tests/TestSuite_unit_tests_timer.py | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/TestSuite_unit_tests_timer.py b/tests/TestSuite_unit_tests_timer.py
>> index f3bb02d..365c5f6 100644
>> --- a/tests/TestSuite_unit_tests_timer.py
>> +++ b/tests/TestSuite_unit_tests_timer.py
>> @@ -78,7 +78,7 @@ class TestUnitTestsTimer(TestCase):
>>           Run timer autotest.
>>           """
>>           self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
>> -        out = self.dut.send_expect("timer_autotest", "RTE>>", this_timeout)
>> +        out = self.dut.send_expect("timer_autotest", "RTE>>", self.this_timeout)
>>           self.dut.send_expect("quit", "# ")
>>           self.verify("Test OK" in out, "Test failed")
>>
>> @@ -87,7 +87,7 @@ class TestUnitTestsTimer(TestCase):
>>           Run timer autotest.
>>           """
>>           self.dut.send_expect("./%s/app/test -n 1 -c %s" % (self.target, self.coremask), "R.*T.*E.*>.*>", 60)
>> -        out = self.dut.send_expect("timer_perf_autotest", "RTE>>", this_timeout)
>> +        out = self.dut.send_expect("timer_perf_autotest", "RTE>>", self.this_timeout)
>>           self.dut.send_expect("quit", "# ")
>>           self.verify("Test OK" in out, "Test failed")
>>
>> --
>> 2.17.1
> 


  reply	other threads:[~2019-07-22 12:18 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-18 18:39 [dts] [PATCH] " Thinh Tran
2019-07-19  8:49 ` Mo, YufengX
2019-07-19 12:59   ` [dts] [PATCH v2] " Thinh Tran
2019-07-22  2:01     ` Mo, YufengX
2019-07-22 12:18       ` Thinh Tran [this message]
2019-07-22 13:15       ` [dts] [PATCH V3] " Thinh Tran
2019-07-23  3:05         ` Mo, YufengX
2019-08-06  9:51         ` Tu, Lijuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=348089e1-3fe9-d8eb-c594-4e19fcda5a8b@linux.vnet.ibm.com \
    --to=thinhtr@linux.vnet.ibm.com \
    --cc=dts@dpdk.org \
    --cc=yufengx.mo@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).