Re: [dts] [PATCH V1] tests/vm_power_manager: change coremask

Re: [dts] [PATCH V1] tests/vm_power_manager: change coremask

[Xie, WeiX]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

Tested-by:  Xie,WeiX < weix.xie@intel.com>

Regards,
Xie Wei


> -----Original Message-----
> From: Xie wei [mailto:weix.xie@intel.com]
> Sent: Wednesday, February 3, 2021 11:10 AM
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [PATCH V1] tests/vm_power_manager: change coremask

[-- Attachment #2: TestVmPowerManager.log --]
[-- Type: application/octet-stream, Size: 159583 bytes --]

[dts] [PATCH V1] tests/vm_power_manager: change coremask

[Xie wei]

according to dpdk commit b49c677, adjust the coremask given to vm_power_manager.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_vm_power_manager.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_vm_power_manager.py b/tests/TestSuite_vm_power_manager.py
index 00910ebd..854e1617 100644
--- a/tests/TestSuite_vm_power_manager.py
+++ b/tests/TestSuite_vm_power_manager.py
@@ -94,7 +94,7 @@ class TestVmPowerManager(TestCase, IxiaPacketGenerator):
         self.path = self.vm_dut.apps_name['guest_cli']
         self.guest_cmd = self.path + "-c 0xf -n 4 -- --vm-name=%s --vcpu-list=0,1,2,3" % self.vm_name
         self.vm_power_dir = self.vm_dut.apps_name['vm_power_manager']
-        mgr_cmd = self.vm_power_dir + "-c 0x7 -n 4"
+        mgr_cmd = self.vm_power_dir + "-c 0x1ff -n 4"
         out = self.dut.send_expect(mgr_cmd, "vmpower>", 120)
         self.dut.send_expect("add_vm %s" % self.vm_name, "vmpower>")
         self.dut.send_expect("add_channels %s all" % self.vm_name, "vmpower>")
-- 
2.17.1

Re: [dts] [PATCH V1] tests/vm_power_manager: change coremask

[Tu, Lijuan]

> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
> Sent: 2021年2月3日 11:10
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/vm_power_manager: change coremask
> 
> according to dpdk commit b49c677, adjust the coremask given to
> vm_power_manager.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>
> ---
>  tests/TestSuite_vm_power_manager.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_vm_power_manager.py
> b/tests/TestSuite_vm_power_manager.py
> index 00910ebd..854e1617 100644
> --- a/tests/TestSuite_vm_power_manager.py
> +++ b/tests/TestSuite_vm_power_manager.py
> @@ -94,7 +94,7 @@ class TestVmPowerManager(TestCase,
> IxiaPacketGenerator):
>          self.path = self.vm_dut.apps_name['guest_cli']
>          self.guest_cmd = self.path + "-c 0xf -n 4 -- --vm-name=%s --vcpu-
> list=0,1,2,3" % self.vm_name
>          self.vm_power_dir = self.vm_dut.apps_name['vm_power_manager']
> -        mgr_cmd = self.vm_power_dir + "-c 0x7 -n 4"
> +        mgr_cmd = self.vm_power_dir + "-c 0x1ff -n 4"

check  cores is necessary before using these cores.
dpdk commit b49c677 said  " 
    When vm_power_manager is started, it takes over power management on
    all cores. This should be limited to cores defined in the core mask.

    When initialising, if a core is not on the coremask, skip it.
    Applies to both initialisation and exit."
So, please go through script, don't missing any other places. The cores that not on core mask will be not taken over by app.

>          out = self.dut.send_expect(mgr_cmd, "vmpower>", 120)
>          self.dut.send_expect("add_vm %s" % self.vm_name, "vmpower>")
>          self.dut.send_expect("add_channels %s all" % self.vm_name, "vmpower>")
> --
> 2.17.1