From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B7AF52B8E for ; Wed, 29 Jun 2016 11:11:58 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 29 Jun 2016 02:11:57 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,545,1459839600"; d="scan'208";a="985485538" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 29 Jun 2016 02:11:57 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 29 Jun 2016 02:11:57 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.147]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.230]) with mapi id 14.03.0248.002; Wed, 29 Jun 2016 17:11:55 +0800 From: "Tu, LijuanX A" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH]tests vf_vlan: enable crc-strip of FLV when start testpmd in vm Thread-Index: AQHR0Z7988SqYbsZE020NPObppp1PqAAJ0KQ Date: Wed, 29 Jun 2016 09:11:54 +0000 Message-ID: <38D041F150D4184C8114E499040E6234072D21EA@shsmsx102.ccr.corp.intel.com> References: <1466751281-27159-1-git-send-email-lijuanx.a.tu@intel.com> <577319F8.60908@intel.com> In-Reply-To: <577319F8.60908@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH]tests vf_vlan: enable crc-strip of FLV when start testpmd in vm X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Jun 2016 09:11:59 -0000 > -----Original Message----- > From: Liu, Yong > Sent: Wednesday, June 29, 2016 8:45 AM > To: Tu, LijuanX A; dts@dpdk.org > Subject: Re: [dts] [PATCH]tests vf_vlan: enable crc-strip of FLV when st= art > testpmd in vm >=20 > Hi Lijuan, one question below. >=20 > On 06/24/2016 02:54 PM, Lijuan Tu wrote: > > For NIC fortville, dpdk16.07 will quit testpmd if VF can't disable HW > > CRC Strip > > > > Signed-off-by: Lijuan Tu > > --- > > tests/TestSuite_vf_vlan.py | 32 ++++++++++++++++++++++++-------- > > 1 file changed, 24 insertions(+), 8 deletions(-) > > > > diff --git a/tests/TestSuite_vf_vlan.py b/tests/TestSuite_vf_vlan.py > > index e32e5bd..1034602 100644 > > --- a/tests/TestSuite_vf_vlan.py > > +++ b/tests/TestSuite_vf_vlan.py > > @@ -152,7 +152,10 @@ class TestVfVlan(TestCase): > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > + if self.kdriver =3D=3D "i40e": > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-stri= p') > > + else: > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > self.vm0_testpmd.execute_cmd('set fwd mac') > > self.vm0_testpmd.execute_cmd('start') > > > > @@ -176,7 +179,7 @@ class TestVfVlan(TestCase): > > pkt.config_layer('ether', {'dst': self.vf0_mac}) > > elif pkt_type =3D=3D "VLAN_UDP": > > pkt =3D Packet(pkt_type=3D'VLAN_UDP') > > - pkt.config_layer('dot1q', {'vlan': vlan}) > > + pkt.config_layer('vlan', {'vlan': vlan}) > > pkt.config_layer('ether', {'dst': self.vf0_mac}) > > > > pkt.send_pkt(tx_port=3Dself.tester_intf0) > > @@ -197,7 +200,10 @@ class TestVfVlan(TestCase): > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > + if self.kdriver =3D=3D "i40e": > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-stri= p') > > + else: > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > self.vm0_testpmd.execute_cmd('set fwd rxonly') > > self.vm0_testpmd.execute_cmd('set verbose 1') > > self.vm0_testpmd.execute_cmd('start') > > @@ -249,7 +255,7 @@ class TestVfVlan(TestCase): > > pkts =3D load_sniff_packets(inst) > > vlans =3D [] > > for pkt in pkts: > > - vlan =3D pkt.strip_element_dot1q("vlan") > > + vlan =3D pkt.strip_element_vlan("vlan") > > vlans.append(vlan) > > > > self.verify( > > @@ -262,7 +268,10 @@ class TestVfVlan(TestCase): > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > + if self.kdriver =3D=3D "i40e": > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-stri= p') > > + else: > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > self.vm0_testpmd.execute_cmd('set verbose 1') > > > > for tx_vlan in tx_vlans: > > @@ -283,10 +292,14 @@ class TestVfVlan(TestCase): > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > + if self.kdriver =3D=3D "i40e": > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-stri= p') > > + else: > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > self.vm0_testpmd.execute_cmd('set fwd rxonly') > > self.vm0_testpmd.execute_cmd('set verbose 1') > > self.vm0_testpmd.execute_cmd('vlan set strip on 0') > > + self.vm0_testpmd.execute_cmd('vlan set filter on 0') > > self.vm0_testpmd.execute_cmd('start') > > > > # send packet without vlan > > @@ -334,7 +347,7 @@ class TestVfVlan(TestCase): > > # send packet with vlan > > out =3D self.send_and_getout(vlan=3Drandom_vlan, pkt_type=3D= "VLAN_UDP") > > self.verify( > > - "received 1 packets" in out, "Not received vlan packet wi= thout > vlan filter!!!") > > + "received 1 packets" not in out, "Not received vlan > > + packet without vlan filter!!!") > The original judgment is that check vlan packet received by testpmd. Why > change this judgment? [lijuan] vlan set filter on port_id ,and then it should not receive packets= . >=20 > > self.vm0_testpmd.quit() > > > > @@ -345,7 +358,10 @@ class TestVfVlan(TestCase): > > self.vm0_dut_ports =3D self.vm_dut_0.get_ports('any') > > > > self.vm0_testpmd =3D PmdOutput(self.vm_dut_0) > > - self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > + if self.kdriver =3D=3D "i40e": > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK, '--crc-stri= p') > > + else: > > + self.vm0_testpmd.start_testpmd(VM_CORES_MASK) > > self.vm0_testpmd.execute_cmd('set fwd rxonly') > > self.vm0_testpmd.execute_cmd('set verbose 1') > > self.vm0_testpmd.execute_cmd('start')