From: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH V1]framework/dut: fix parameter error on some OS
Date: Wed, 18 Jan 2017 08:38:56 +0000 [thread overview]
Message-ID: <38D041F150D4184C8114E499040E62343D1E2E51@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62D4C4CA@SHSMSX103.ccr.corp.intel.com>
Hi yong,
I will change it ,and sent patch later.
> -----Original Message-----
> From: Liu, Yong
> Sent: Wednesday, January 18, 2017 4:03 PM
> To: Tu, LijuanX A; dts@dpdk.org
> Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on some OS
>
> Hi Lijuan,
> Function destroy_all_sriov_vfs should be workable on different OSs.
> If FreeBSD not support virtualization cases, we can just add one blank
> function for FreeBSD OS to work around this issue.
>
> Thanks,
> Marvin
> > -----Original Message-----
> > From: Tu, LijuanX A
> > Sent: Wednesday, January 18, 2017 10:49 AM
> > To: Liu, Yong <yong.liu@intel.com>; dts@dpdk.org
> > Subject: RE: [dts] [PATCH V1]framework/dut: fix parameter error on
> > some OS
> >
> > Hi yong,
> > We have function "get_sriov_vfs_pci_linux"
> > but not have function "get_sriov_vfs_pci_freebsd"
> > in framework.
> > So I think we don't support on FreeBSD now.
> >
> > > -----Original Message-----
> > > From: Liu, Yong
> > > Sent: Wednesday, January 18, 2017 10:41 AM > To: Tu, LijuanX A;
> > dts@dpdk.org > Cc: Tu, LijuanX A > Subject: RE: [dts] [PATCH
> > V1]framework/dut: fix parameter error on some OS > > Hi Lijuan, >
> > Virtualization case may not support on FreeBSD, but I think >
> > destroy_all_sriov_vfs this function should has FreeBSD and Linux version.
> > >
> > > > -----Original Message-----
> > > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Lijuan Tu > >
> Sent:
> > Tuesday, January 17, 2017 3:09 PM > > To: dts@dpdk.org > > Cc: Tu,
> > LijuanX A <lijuanx.a.tu@intel.com> > > Subject: [dts] [PATCH
> > V1]framework/dut: fix parameter error on some OS > > > > Virtual test is
> only support linux now.
> > > > Framework not support freebsd
> > > >
> > > > Signed-off-by: Lijuan Tu <lijuanx.a.tu@intel.com> > > --- > >
> > framework/dut.py | 3 +++ > > 1 file changed, 3 insertions(+) > > >
> > > diff --git a/framework/dut.py b/framework/dut.py index
> > 9cbdaf7..0cc45dd > >
> > 100644 > > --- a/framework/dut.py > > +++ b/framework/dut.py > > @@
> > -
> > 820,6 +820,9 @@ class Dut(Crb):
> > > >
> > > > def destroy_all_sriov_vfs(self):
> > > >
> > > > + # virtual test is only support linux now.
> > > > + if self.get_os_type() != "linux":
> > > > +
> > > > if self.ports_info == None:
> > > > return
> > > > for port_id in range(len(self.ports_info)):
> > > > --
> > > > 1.9.3
prev parent reply other threads:[~2017-01-18 8:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 7:08 Lijuan Tu
2017-01-18 2:41 ` Liu, Yong
2017-01-18 2:49 ` Tu, LijuanX A
2017-01-18 8:03 ` Liu, Yong
2017-01-18 8:38 ` Tu, LijuanX A [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38D041F150D4184C8114E499040E62343D1E2E51@shsmsx102.ccr.corp.intel.com \
--to=lijuanx.a.tu@intel.com \
--cc=dts@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).