test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, LijuanX A" <lijuanx.a.tu@intel.com>
To: "Xu, GangX" <gangx.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xu, GangX" <gangx.xu@intel.com>
Subject: Re: [dts] [PATCH V3] add tx-offloads to start testpmd in	checksum_offload test suite
Date: Mon, 29 Jan 2018 08:48:29 +0000	[thread overview]
Message-ID: <38D041F150D4184C8114E499040E62343DCA8650@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1517215414-33503-1-git-send-email-gangx.xu@intel.com>

Hi Gang,

This suite contain enable/disable offload , your patch will enable offload for all cases.
I think you should stop port and then set checksum offload , this will be a better solution.

-----Original Message-----
From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang
Sent: Monday, January 29, 2018 4:44 PM
To: dts@dpdk.org
Cc: Xu, GangX <gangx.xu@intel.com>
Subject: [dts] [PATCH V3] add tx-offloads to start testpmd in checksum_offload test suite

open IPV4_CKSUM UDP_CKSUM TCP_CKSUM SCTP_CKSUM TX_offload 

Signed-off-by: xu,gang <gangx.xu@intel.com>
---
 tests/TestSuite_checksum_offload.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py
index 5f5547f..f82514c 100644
--- a/tests/TestSuite_checksum_offload.py
+++ b/tests/TestSuite_checksum_offload.py
@@ -67,7 +67,7 @@ class TestChecksumOffload(TestCase):
         """
         self.pmdout.start_testpmd("Default", "--portmask=%s " %
                                   (self.portMask) + "--disable-hw-vlan --enable-rx-cksum " +
-                                  "--port-topology=loop", socket=self.ports_socket)
+                                  "--port-topology=loop --tx-offloads=0x1e", socket=self.ports_socket)
         self.dut.send_expect("set verbose 1", "testpmd>")
         self.dut.send_expect("set fwd csum", "testpmd>")
 
-- 
1.9.3

      reply	other threads:[~2018-01-29  8:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29  8:43 xu,gang
2018-01-29  8:48 ` Tu, LijuanX A [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=38D041F150D4184C8114E499040E62343DCA8650@SHSMSX103.ccr.corp.intel.com \
    --to=lijuanx.a.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=gangx.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).