From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id D83FF1B343 for ; Tue, 30 Jan 2018 03:27:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Jan 2018 18:27:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,433,1511856000"; d="scan'208";a="30491318" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 29 Jan 2018 18:27:44 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 18:27:44 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 29 Jan 2018 18:27:43 -0800 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.145]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.130]) with mapi id 14.03.0319.002; Tue, 30 Jan 2018 10:27:42 +0800 From: "Tu, LijuanX A" To: "Liu, Yong" , "Xu, GangX" , "dts@dpdk.org" CC: "Xu, GangX" Thread-Topic: [dts] [PATCH V4] stop port before csum set Thread-Index: AQHTmOnZSmlDgEsh/kSgpJZJ53ii5qOLKAYAgACIyxA= Date: Tue, 30 Jan 2018 02:27:42 +0000 Message-ID: <38D041F150D4184C8114E499040E62343DCA904F@SHSMSX103.ccr.corp.intel.com> References: <1517220872-34024-1-git-send-email-gangx.xu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E62F7ADBA@SHSMSX103.ccr.corp.intel.com> In-Reply-To: <86228AFD5BCD8E4EBFD2B90117B5E81E62F7ADBA@SHSMSX103.ccr.corp.intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZWRhZTgyMTItNGU5MS00MTdlLWI5NmItYzQyNmNlOTNjNDNmIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJSMWJtZVNTYlF2a3hoSTE2MmNUUGVFcldwTFRZZG1lZk05WDBOblZJZmtRNVZDaFM5aDVkcUk5bnRQZUlkcFNwIn0= x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH V4] stop port before csum set X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 02:27:46 -0000 Hi Marvin, In this case ,we don't need set csum related offload when start testpmd. When we run command "csum set ip/udp/tcp/sctp hw $port_id", dpdk will set c= sum offload. And we run command "csum set ip/udp/tcp/sctp sw $port_id", dpdk will remove= csum offload. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong Sent: Tuesday, January 30, 2018 10:14 AM To: Xu, GangX ; dts@dpdk.org Cc: Xu, GangX Subject: Re: [dts] [PATCH V4] stop port before csum set Gang, You forgot to add tx offloads in this patch. + "--port-topology=3Dloop --tx-offloads=3D= 0x1e", socket=3Dself.ports_socket) > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Monday, January 29, 2018 6:15 PM > To: dts@dpdk.org > Cc: Xu, GangX > Subject: [dts] [PATCH V4] stop port before csum set >=20 > Need to stop port before configure csum. > refer dpdk commit : 597f9fafe13b >=20 > Signed-off-by: xu,gang > --- > tests/TestSuite_checksum_offload.py | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index 5f5547f..4183ead 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase): > self.dut.send_expect("set fwd csum", "testpmd>") >=20 > def checksum_enablehw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip hw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp hw %d" % port, "testpmd>"= ) > self.dut.send_expect("csum set tcp hw %d" % port, "testpmd>"= ) > self.dut.send_expect("csum set sctp hw %d" % port, "testpmd>= ") > + self.dut.send_expect("port start all", "testpmd>") >=20 > def checksum_enablesw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip sw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp sw %d" % port, "testpmd>"= ) > self.dut.send_expect("csum set tcp sw %d" % port, "testpmd>"= ) > self.dut.send_expect("csum set sctp sw %d" % port, "testpmd>= ") > + self.dut.send_expect("port start all", "testpmd>") > + >=20 > def get_chksum_values(self, packets_expected): > """ > -- > 1.9.3