* [dts] [PATCH V4] stop port before csum set @ 2018-01-29 10:14 xu,gang 2018-01-30 2:13 ` Liu, Yong 2018-01-30 11:06 ` Liu, Yong 0 siblings, 2 replies; 5+ messages in thread From: xu,gang @ 2018-01-29 10:14 UTC (permalink / raw) To: dts; +Cc: xu,gang Need to stop port before configure csum. refer dpdk commit : 597f9fafe13b Signed-off-by: xu,gang <gangx.xu@intel.com> --- tests/TestSuite_checksum_offload.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/tests/TestSuite_checksum_offload.py b/tests/TestSuite_checksum_offload.py index 5f5547f..4183ead 100644 --- a/tests/TestSuite_checksum_offload.py +++ b/tests/TestSuite_checksum_offload.py @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase): self.dut.send_expect("set fwd csum", "testpmd>") def checksum_enablehw(self, port): + self.dut.send_expect("port stop all", "testpmd>") self.dut.send_expect("csum set ip hw %d" % port, "testpmd>") self.dut.send_expect("csum set udp hw %d" % port, "testpmd>") self.dut.send_expect("csum set tcp hw %d" % port, "testpmd>") self.dut.send_expect("csum set sctp hw %d" % port, "testpmd>") + self.dut.send_expect("port start all", "testpmd>") def checksum_enablesw(self, port): + self.dut.send_expect("port stop all", "testpmd>") self.dut.send_expect("csum set ip sw %d" % port, "testpmd>") self.dut.send_expect("csum set udp sw %d" % port, "testpmd>") self.dut.send_expect("csum set tcp sw %d" % port, "testpmd>") self.dut.send_expect("csum set sctp sw %d" % port, "testpmd>") + self.dut.send_expect("port start all", "testpmd>") + def get_chksum_values(self, packets_expected): """ -- 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V4] stop port before csum set 2018-01-29 10:14 [dts] [PATCH V4] stop port before csum set xu,gang @ 2018-01-30 2:13 ` Liu, Yong 2018-01-30 2:27 ` Tu, LijuanX A 2018-01-30 11:06 ` Liu, Yong 1 sibling, 1 reply; 5+ messages in thread From: Liu, Yong @ 2018-01-30 2:13 UTC (permalink / raw) To: Xu, GangX, dts; +Cc: Xu, GangX Gang, You forgot to add tx offloads in this patch. + "--port-topology=loop --tx-offloads=0x1e", socket=self.ports_socket) > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Monday, January 29, 2018 6:15 PM > To: dts@dpdk.org > Cc: Xu, GangX <gangx.xu@intel.com> > Subject: [dts] [PATCH V4] stop port before csum set > > Need to stop port before configure csum. > refer dpdk commit : 597f9fafe13b > > Signed-off-by: xu,gang <gangx.xu@intel.com> > --- > tests/TestSuite_checksum_offload.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index 5f5547f..4183ead 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase): > self.dut.send_expect("set fwd csum", "testpmd>") > > def checksum_enablehw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip hw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp hw %d" % port, "testpmd>") > self.dut.send_expect("csum set tcp hw %d" % port, "testpmd>") > self.dut.send_expect("csum set sctp hw %d" % port, "testpmd>") > + self.dut.send_expect("port start all", "testpmd>") > > def checksum_enablesw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip sw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp sw %d" % port, "testpmd>") > self.dut.send_expect("csum set tcp sw %d" % port, "testpmd>") > self.dut.send_expect("csum set sctp sw %d" % port, "testpmd>") > + self.dut.send_expect("port start all", "testpmd>") > + > > def get_chksum_values(self, packets_expected): > """ > -- > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V4] stop port before csum set 2018-01-30 2:13 ` Liu, Yong @ 2018-01-30 2:27 ` Tu, LijuanX A 2018-01-30 2:52 ` Liu, Yong 0 siblings, 1 reply; 5+ messages in thread From: Tu, LijuanX A @ 2018-01-30 2:27 UTC (permalink / raw) To: Liu, Yong, Xu, GangX, dts; +Cc: Xu, GangX Hi Marvin, In this case ,we don't need set csum related offload when start testpmd. When we run command "csum set ip/udp/tcp/sctp hw $port_id", dpdk will set csum offload. And we run command "csum set ip/udp/tcp/sctp sw $port_id", dpdk will remove csum offload. -----Original Message----- From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong Sent: Tuesday, January 30, 2018 10:14 AM To: Xu, GangX <gangx.xu@intel.com>; dts@dpdk.org Cc: Xu, GangX <gangx.xu@intel.com> Subject: Re: [dts] [PATCH V4] stop port before csum set Gang, You forgot to add tx offloads in this patch. + "--port-topology=loop --tx-offloads=0x1e", socket=self.ports_socket) > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > Sent: Monday, January 29, 2018 6:15 PM > To: dts@dpdk.org > Cc: Xu, GangX <gangx.xu@intel.com> > Subject: [dts] [PATCH V4] stop port before csum set > > Need to stop port before configure csum. > refer dpdk commit : 597f9fafe13b > > Signed-off-by: xu,gang <gangx.xu@intel.com> > --- > tests/TestSuite_checksum_offload.py | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/TestSuite_checksum_offload.py > b/tests/TestSuite_checksum_offload.py > index 5f5547f..4183ead 100644 > --- a/tests/TestSuite_checksum_offload.py > +++ b/tests/TestSuite_checksum_offload.py > @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase): > self.dut.send_expect("set fwd csum", "testpmd>") > > def checksum_enablehw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip hw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp hw %d" % port, "testpmd>") > self.dut.send_expect("csum set tcp hw %d" % port, "testpmd>") > self.dut.send_expect("csum set sctp hw %d" % port, "testpmd>") > + self.dut.send_expect("port start all", "testpmd>") > > def checksum_enablesw(self, port): > + self.dut.send_expect("port stop all", "testpmd>") > self.dut.send_expect("csum set ip sw %d" % port, "testpmd>") > self.dut.send_expect("csum set udp sw %d" % port, "testpmd>") > self.dut.send_expect("csum set tcp sw %d" % port, "testpmd>") > self.dut.send_expect("csum set sctp sw %d" % port, "testpmd>") > + self.dut.send_expect("port start all", "testpmd>") > + > > def get_chksum_values(self, packets_expected): > """ > -- > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V4] stop port before csum set 2018-01-30 2:27 ` Tu, LijuanX A @ 2018-01-30 2:52 ` Liu, Yong 0 siblings, 0 replies; 5+ messages in thread From: Liu, Yong @ 2018-01-30 2:52 UTC (permalink / raw) To: Tu, LijuanX A, Xu, GangX, dts; +Cc: Xu, GangX Lijuan, thanks for clear. > -----Original Message----- > From: Tu, LijuanX A > Sent: Tuesday, January 30, 2018 10:28 AM > To: Liu, Yong <yong.liu@intel.com>; Xu, GangX <gangx.xu@intel.com>; > dts@dpdk.org > Cc: Xu, GangX <gangx.xu@intel.com> > Subject: RE: [dts] [PATCH V4] stop port before csum set > > Hi Marvin, > > In this case ,we don't need set csum related offload when start testpmd. > When we run command "csum set ip/udp/tcp/sctp hw $port_id", dpdk will set > csum offload. > And we run command "csum set ip/udp/tcp/sctp sw $port_id", dpdk will > remove csum offload. > > > -----Original Message----- > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Liu, Yong > Sent: Tuesday, January 30, 2018 10:14 AM > To: Xu, GangX <gangx.xu@intel.com>; dts@dpdk.org > Cc: Xu, GangX <gangx.xu@intel.com> > Subject: Re: [dts] [PATCH V4] stop port before csum set > > Gang, > You forgot to add tx offloads in this patch. > > + "--port-topology=loop --tx- > offloads=0x1e", socket=self.ports_socket) > > > > -----Original Message----- > > From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xu,gang > > Sent: Monday, January 29, 2018 6:15 PM > > To: dts@dpdk.org > > Cc: Xu, GangX <gangx.xu@intel.com> > > Subject: [dts] [PATCH V4] stop port before csum set > > > > Need to stop port before configure csum. > > refer dpdk commit : 597f9fafe13b > > > > Signed-off-by: xu,gang <gangx.xu@intel.com> > > --- > > tests/TestSuite_checksum_offload.py | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tests/TestSuite_checksum_offload.py > > b/tests/TestSuite_checksum_offload.py > > index 5f5547f..4183ead 100644 > > --- a/tests/TestSuite_checksum_offload.py > > +++ b/tests/TestSuite_checksum_offload.py > > @@ -72,16 +72,21 @@ class TestChecksumOffload(TestCase): > > self.dut.send_expect("set fwd csum", "testpmd>") > > > > def checksum_enablehw(self, port): > > + self.dut.send_expect("port stop all", "testpmd>") > > self.dut.send_expect("csum set ip hw %d" % port, "testpmd>") > > self.dut.send_expect("csum set udp hw %d" % port, > "testpmd>") > > self.dut.send_expect("csum set tcp hw %d" % port, > "testpmd>") > > self.dut.send_expect("csum set sctp hw %d" % port, > "testpmd>") > > + self.dut.send_expect("port start all", "testpmd>") > > > > def checksum_enablesw(self, port): > > + self.dut.send_expect("port stop all", "testpmd>") > > self.dut.send_expect("csum set ip sw %d" % port, "testpmd>") > > self.dut.send_expect("csum set udp sw %d" % port, > "testpmd>") > > self.dut.send_expect("csum set tcp sw %d" % port, > "testpmd>") > > self.dut.send_expect("csum set sctp sw %d" % port, > "testpmd>") > > + self.dut.send_expect("port start all", "testpmd>") > > + > > > > def get_chksum_values(self, packets_expected): > > """ > > -- > > 1.9.3 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dts] [PATCH V4] stop port before csum set 2018-01-29 10:14 [dts] [PATCH V4] stop port before csum set xu,gang 2018-01-30 2:13 ` Liu, Yong @ 2018-01-30 11:06 ` Liu, Yong 1 sibling, 0 replies; 5+ messages in thread From: Liu, Yong @ 2018-01-30 11:06 UTC (permalink / raw) To: xu,gang, dts Thanks Gang. Applied. On 01/29/2018 06:14 PM, xu,gang wrote: > Need to stop port before configure csum. > refer dpdk commit : 597f9fafe13b > > Signed-off-by: xu,gang<gangx.xu@intel.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-01-30 3:15 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-01-29 10:14 [dts] [PATCH V4] stop port before csum set xu,gang 2018-01-30 2:13 ` Liu, Yong 2018-01-30 2:27 ` Tu, LijuanX A 2018-01-30 2:52 ` Liu, Yong 2018-01-30 11:06 ` Liu, Yong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).