test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Juraj Linkeš" <juraj.linkes@pantheon.tech>
To: Jun Dong <junx.dong@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "lijuan.tu@intel.com" <lijuan.tu@intel.com>,
	"qingx.sun@intel.com" <qingx.sun@intel.com>
Subject: RE: [dts] [V4] framework/*: Modified create_eal_parameters API to support flexibility
Date: Mon, 14 Mar 2022 10:10:16 +0000	[thread overview]
Message-ID: <3dc1249a1e5e4368a3950ed954f54259@pantheon.tech> (raw)
In-Reply-To: <20220303015715.4668-1-junx.dong@intel.com>

> Subject: [dts] [V4] framework/*: Modified create_eal_parameters API to
> support flexibility
> 
> Signed-off-by: Jun Dong <junx.dong@intel.com>


>  class ParameterInvalidException(Exception):
> -    pass
> +    def __init__(self, param_name: str, param_value: Any):
> +        self.param_name = param_name
> +        self.param_value = param_value
> +
> +    def __str__(self) -> str:
> +        return f'Invalid parameter of {self.param_name} about value of
> {self.param_value}, Please reference API doc.'
> +
> 

Hi Jun, the above section of the patch introduced these errors:
framework/tester.py:277: [E] E1120 No value for argument 'param_value' in constructor call [pylint]
framework/tester.py:286: [E] E1120 No value for argument 'param_value' in constructor call [pylint]
framework/tester.py:298: [E] E1120 No value for argument 'param_value' in constructor call [pylint]

Would you please fix the usage of the newly implemented exception?

Thanks,
Juraj


  reply	other threads:[~2022-03-14 10:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-03  1:57 Jun Dong
2022-03-14 10:10 ` Juraj Linkeš [this message]
2022-03-15  1:38   ` Dong, JunX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dc1249a1e5e4368a3950ed954f54259@pantheon.tech \
    --to=juraj.linkes@pantheon.tech \
    --cc=dts@dpdk.org \
    --cc=junx.dong@intel.com \
    --cc=lijuan.tu@intel.com \
    --cc=qingx.sun@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).