test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhang, XiX" <xix.zhang@intel.com>
To: "dts@dpdk.org" <dts@dpdk.org>, "Tu, Lijuan" <lijuan.tu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_ieee1588:Modify sed command
Date: Thu, 17 Sep 2020 05:19:07 +0000	[thread overview]
Message-ID: <47146484d8e04eeaac052b4d5ff211b4@intel.com> (raw)
In-Reply-To: <1600254387-20435-1-git-send-email-xix.zhang@intel.com>

Hi  Lijuan
Please ignore this patch, I will re submit patch v2


Regards,
Zhang, Xi



> -----Original Message-----
> From: Zhang, XiX
> Sent: Wednesday, September 16, 2020 7:06 PM
> To: dts@dpdk.org
> Subject: RE: [dts][PATCH V1] tests/TestSuite_ieee1588:Modify sed command
> 
> Tested-by: Zhang, XiX <xix.zhang@intel.com>
> 
> > -----Original Message-----
> > From: Zhang, XiX
> > Sent: Wednesday, September 16, 2020 7:06 PM
> > To: dts@dpdk.org
> > Cc: Zhang, XiX <xix.zhang@intel.com>
> > Subject: [dts][PATCH V1] tests/TestSuite_ieee1588:Modify sed command
> >
> >
> > Modify sed command
> >
> >
> > Signed-off-by: xizhan4x <xix.zhang@intel.com>
> > ---
> >  tests/TestSuite_ieee1588.py | 15 ++++++++++-----
> >  1 file changed, 10 insertions(+), 5 deletions(-)
> >
> > diff --git a/tests/TestSuite_ieee1588.py b/tests/TestSuite_ieee1588.py
> > index
> > 19f17d1..8632286 100644
> > --- a/tests/TestSuite_ieee1588.py
> > +++ b/tests/TestSuite_ieee1588.py
> > @@ -56,6 +56,7 @@ class TestIeee1588(TestCase):
> >          # Change the config file to support IEEE1588 and recompile
> > the package.
> >          self.dut.send_expect(
> >              "sed -i -e 's/IEEE1588=n$/IEEE1588=y/'
> > config/common_base", "# ", 30)
> > +        self.dut.set_build_options({'RTE_LIBRTE_IEEE1588': 'y'})
> >          self.dut.skip_setup = False
> >          self.dut.build_install_dpdk(self.target)
> >
> > @@ -91,18 +92,21 @@ class TestIeee1588(TestCase):
> >          port = self.tester.get_local_port(dutPorts[0])
> >          itf = self.tester.get_interface(port)
> >
> > -        self.tester.send_expect(
> > -            "tcpdump -i %s -e ether src %s" % (itf, mac), "tcpdump", 20)
> >          self.send_session =
> > self.tester.create_session('send_session')
> > +        self.send_session.send_expect(
> > +            "tcpdump -i %s -e ether src %s" % (itf, mac), "tcpdump",
> > + 20)
> > +
> >          setattr(self.send_session, 'tmp_file', self.tester.tmp_file)
> > +        setattr(self.send_session, 'tmp_file',
> > + self.tester.get_session_output)
> >          pkt = Packet(pkt_type='TIMESYNC')
> >          pkt.config_layer('ether', {'dst': mac})
> > -        pkt.send_pkt(self.send_session, tx_port=itf)
> > +        pkt.send_pkt(self.tester, tx_port=itf)
> >          time.sleep(1)
> > +
> > +        out = self.send_session.get_session_output(timeout=20)
> > +        self.send_session.send_expect("^C", "# ", 20)
> >          self.send_session.close()
> > -        out = self.tester.get_session_output(timeout=20)
> >
> > -        self.tester.send_expect("^C", "# ", 20)
> >
> >          self.verify("0x88f7" in out, "Ether type is not PTP")
> >
> > @@ -171,4 +175,5 @@ class TestIeee1588(TestCase):
> >          # Restore the config file and recompile the package.
> >          self.dut.send_expect(
> >              "sed -i -e 's/IEEE1588=y$/IEEE1588=n/'
> > config/common_base", "# ", 30)
> > +        self.dut.set_build_options({'RTE_LIBRTE_IEEE1588': 'n'})
> >          self.dut.build_install_dpdk(self.target)
> > --
> > 1.8.3.1


  parent reply	other threads:[~2020-09-17  5:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16 11:06 xizhan4x
2020-09-16 11:06 ` Zhang, XiX
2020-09-17  5:19 ` Zhang, XiX [this message]
2020-09-17  8:21 ` Ma, LihongX
2020-09-22  7:45   ` Zhang, XiX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47146484d8e04eeaac052b4d5ff211b4@intel.com \
    --to=xix.zhang@intel.com \
    --cc=dts@dpdk.org \
    --cc=lijuan.tu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).