test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
To: "Li, WenjieX A" <wenjiex.a.li@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Li, WenjieX A" <wenjiex.a.li@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V2] update the thread number
Date: Wed, 20 Mar 2019 01:35:24 +0000	[thread overview]
Message-ID: <4DC48DF9BDA3E54A836D2D3C057DEC6F0B1557C0@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1552987286-69185-1-git-send-email-wenjiex.a.li@intel.com>

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Wenjie Li
> Sent: Tuesday, March 19, 2019 5:21 PM
> To: dts@dpdk.org
> Cc: Li, WenjieX A <wenjiex.a.li@intel.com>
> Subject: [dts] [PATCH V2] update the thread number
> 
> 1. the thread number should be equal to the port number, update it 2. move
> dut.kill_all() to tear_down() to avoid the interactions between cases
> 
> Signed-off-by: Wenjie Li <wenjiex.a.li@intel.com>
> V2: add "sed -i ..." to set_ports()
> V1: wrongly add "sed -i ..." to set_table()
> ---
>  tests/TestSuite_flow_classify_softnic.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_flow_classify_softnic.py
> b/tests/TestSuite_flow_classify_softnic.py
> index 66db5c3..dd05769 100644
> --- a/tests/TestSuite_flow_classify_softnic.py
> +++ b/tests/TestSuite_flow_classify_softnic.py
> @@ -109,6 +109,7 @@ class TestFlowClassifySoftnic(TestCase):
>              self.dut.send_expect(cmd, "# ", 20)
>              cmd = "sed -i '4i\link LINK3
> dev %s' ./drivers/net/softnic/flow_classify_softnic/%s" % (self.dut_p3_pci,
> filename)
>              self.dut.send_expect(cmd, "# ", 20)
> +        self.dut.send_expect("sed -i 's/^thread 4 pipeline/thread %d
> + pipeline/g' ./drivers/net/softnic/flow_classify_softnic/%s" %
> + (self.port_num, filename), "# ", 20)
> 
>      def set_table(self, cmd, filename):
>          """
> @@ -1349,10 +1350,10 @@ class TestFlowClassifySoftnic(TestCase):
>          """
>          Run after each test case.
>          """
> -        pass
> +        self.dut.kill_all()
> 
>      def tear_down_all(self):
>          """
>          Run after each test suite.
>          """
> -        self.dut.kill_all()
> +        pass
> --
> 2.17.2


      reply	other threads:[~2019-03-20  1:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19  9:21 Wenjie Li
2019-03-20  1:35 ` Zhu, ShuaiX [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC48DF9BDA3E54A836D2D3C057DEC6F0B1557C0@SHSMSX101.ccr.corp.intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=wenjiex.a.li@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).