test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Zhu, ShuaiX" <shuaix.zhu@intel.com>
To: "Zhang, YanX A" <yanx.a.zhang@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Zhang, YanX A" <yanx.a.zhang@intel.com>,
	"Zhu, ShuaiX" <shuaix.zhu@intel.com>
Subject: Re: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to	forbid misc packets
Date: Tue, 2 Jul 2019 07:51:57 +0000	[thread overview]
Message-ID: <4DC48DF9BDA3E54A836D2D3C057DEC6F0B1BBA08@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1562052995-126338-1-git-send-email-yanx.a.zhang@intel.com>

Tested-by: Zhu, ShuaiX <shuaix.zhu@intel.com>

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhang,yan
> Sent: Tuesday, July 2, 2019 3:37 PM
> To: dts@dpdk.org
> Cc: Zhang, YanX A <yanx.a.zhang@intel.com>
> Subject: [dts] [PATCH V1] tests/TestSuite_sriov_kvm:disable promisc mode to
> forbid misc packets
> 
> 1. disable promisc mode to forbid misc packets.
> 2. Add judge NIC type, make test_two_vms_add_multi_exact_mac_on_vf
> applies to fortpark, sagevill, and sagepond NIC.
> 
> Signed-off-by: zhang,yan <yanx.a.zhang@intel.com>
> ---
>  tests/TestSuite_sriov_kvm.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/TestSuite_sriov_kvm.py b/tests/TestSuite_sriov_kvm.py index
> eadeb05..3518f8f 100644
> --- a/tests/TestSuite_sriov_kvm.py
> +++ b/tests/TestSuite_sriov_kvm.py
> @@ -627,12 +627,14 @@ class TestSriovKvm(TestCase):
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0)
>          self.vm0_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm0_testpmd.execute_cmd('set fwd rxonly')
> +        self.vm0_testpmd.execute_cmd('set promisc all off')
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.vm1_dut_ports = self.vm_dut_1.get_ports('any')
>          self.vm1_testpmd = PmdOutput(self.vm_dut_1)
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd('set promisc all off')
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -676,6 +678,7 @@ class
> TestSriovKvm(TestCase):
>          self.vm1_testpmd.start_testpmd(VM_CORES_MASK)
>          vf1_mac = self.vm1_testpmd.get_port_mac(port_id_0)
>          self.vm1_testpmd.execute_cmd('set fwd mac')
> +        self.vm1_testpmd.execute_cmd("set promisc all off")
>          self.vm1_testpmd.execute_cmd('start')
> 
>          self.vm0_testpmd = PmdOutput(self.vm_dut_0) @@ -683,6 +686,7
> @@ class TestSriovKvm(TestCase):
>              VM_CORES_MASK, "--eth-peer=0,%s" % vf1_mac)
>          vf0_mac = self.vm0_testpmd.get_port_mac(port_id_0)
>          self.vm0_testpmd.execute_cmd('set fwd mac')
> +        self.vm0_testpmd.execute_cmd("set promisc all off")
>          self.vm0_testpmd.execute_cmd('start')
> 
>          self.setup_2vm_prerequisite_flag = 1 @@ -982,9 +986,9 @@ class
> TestSriovKvm(TestCase):
>          packet_num = 10
> 
>          for vf_mac in ["00:11:22:33:44:55", "00:55:44:33:22:11"]:
> -            if self.nic.startswith('niantic'):
> +            if self.nic.startswith('niantic') or self.nic.startswith('sage'):
>                  set_mac_cmd = "mac_addr add port %d vf %d %s"
> -            elif self.nic.startswith('fortville'):
> +            elif self.nic.startswith('fortville') or
> self.nic.startswith('fortpark'):
>                  set_mac_cmd = "set port %d vf %d %s exact-mac-vlan on"
>              self.host_testpmd.execute_cmd(set_mac_cmd % (port_id_0,
> vf_num, vf_mac))
> 
> --
> 2.17.2


  reply	other threads:[~2019-07-02  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02  7:36 zhang,yan
2019-07-02  7:51 ` Zhu, ShuaiX [this message]
2019-07-03  5:42 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2019-07-02  7:33 zhang,yan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC48DF9BDA3E54A836D2D3C057DEC6F0B1BBA08@SHSMSX101.ccr.corp.intel.com \
    --to=shuaix.zhu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yanx.a.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).