Re: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS

["Zhu, ShuaiX" <shuaix.zhu@intel.com>]

Hi lihong,
    Time.sleep needs to be added after the first process starts, waiting for the second start. If placed after the second process, the second process cannot be started.

> -----Original Message-----
> From: Ma, LihongX
> Sent: Wednesday, November 6, 2019 9:12 AM
> To: Zhu, ShuaiX <shuaix.zhu@intel.com>; dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: RE: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS
> 
> Hi, shuai
> I think you time.sleep(3) should add after the command '
> self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)'
> Because you only wait the first app but not wait the second app.
> And I think you can use ' Checking' or 'Port' instead of ' ' as a expected word.
> 
> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of zhu,shuai
> Sent: Tuesday, November 5, 2019 2:22 PM
> To: dts@dpdk.org
> Cc: Wang, Yinan <yinan.wang@intel.com>; Zhu, ShuaiX <shuaix.zhu@intel.com>
> Subject: [dts] [PATCH V1] tests/vdev_primary_secondary:disable RSS
> 
> RSS is not support by virito device and will thus will return error configure device
> with RSS enabled. Need to disable RSS when configuring virtio device.
> 
> Signed-off-by: zhu,shuai <shuaix.zhu@intel.com>
> ---
>  tests/TestSuite_vdev_primary_secondary.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/TestSuite_vdev_primary_secondary.py
> b/tests/TestSuite_vdev_primary_secondary.py
> index 8b7b899..102a9e0 100644
> --- a/tests/TestSuite_vdev_primary_secondary.py
> +++ b/tests/TestSuite_vdev_primary_secondary.py
> @@ -119,6 +119,7 @@ class TestVdevPrimarySecondary(TestCase):
>          final_cmd_first = example_cmd_auto % (self.mem_channels,
> self.queues)
>          final_cmd_secondary = example_cmd_secondary %
> (self.mem_channels, self.queues)
>          self.vhost_first.send_expect(final_cmd_first, " ", 120)
> +        time.sleep(3)
>          self.vhost_secondary.send_expect(final_cmd_secondary, " ", 120)
> 
> 
> @@ -126,6 +127,8 @@ class TestVdevPrimarySecondary(TestCase):
> 
> self.vm_dut.send_expect("cp ./examples/multi_process/symmetric_mp/main.c
> .", "#")
>          self.vm_dut.send_expect(
>                  "sed -i '/.offloads =
> DEV_RX_OFFLOAD_CHECKSUM,/d' ./examples/multi_process/symmetric_mp/m
> ain.c", "#")
> +        self.vm_dut.send_expect(
> +                "sed -i 's/.mq_mode        =
> ETH_MQ_RX_RSS,/.mq_mode        =
> ETH_MQ_RX_NONE,/g' ./examples/multi_process/symmetric_mp/main.c", "#")
>          out =
> self.vm_dut.build_dpdk_apps('./examples/multi_process/symmetric_mp')
>          self.verify("Error" not in out, "compilation symmetric_mp error")
> 
> --
> 2.17.2