test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Tu, Lijuan" <lijuan.tu@intel.com>
To: "Xie, WeiX" <weix.xie@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Cc: "Xie, WeiX" <weix.xie@intel.com>
Subject: Re: [dts] [PATCH V1] tests/ddp_mpls: compatible with iavf and i40evf for vf
Date: Tue, 30 Mar 2021 01:53:55 +0000
Message-ID: <4c10f7eb6a0a4815a40ebe443f4ed840@intel.com> (raw)
In-Reply-To: <20210325171644.25055-1-weix.xie@intel.com>



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of xiewei
> Sent: 2021年3月26日 1:17
> To: dts@dpdk.org
> Cc: Xie, WeiX <weix.xie@intel.com>
> Subject: [dts] [PATCH V1] tests/ddp_mpls: compatible with iavf and i40evf for vf
> 
> iavf has rss hash rx offload capability by default, but i40evf not have.
> So the hash value and rx queue number will be random when receive wrong label
> MPLS packets.
> If want to wrong label packets received by default queue 0, just launch test-pmd
> with parameter "--disable-rss".
> 
> Signed-off-by: xiewei <weix.xie@intel.com>
> ---
>  tests/TestSuite_ddp_mpls.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/TestSuite_ddp_mpls.py b/tests/TestSuite_ddp_mpls.py index
> 53fd4a76..f0c28386 100644
> --- a/tests/TestSuite_ddp_mpls.py
> +++ b/tests/TestSuite_ddp_mpls.py
> @@ -39,6 +39,7 @@ from test_case import TestCase  from pmd_output import
> PmdOutput  from settings import get_nic_name  import random
> +import re
> 
>  VM_CORES_MASK = 'all'
>  PF_MAX_QUEUE = 64
> @@ -131,7 +132,12 @@ class Testddp_mpls(TestCase):
>          self.vm0_testpmd.start_testpmd(
>              VM_CORES_MASK,"--port-topology=chained --txq=%s --rxq=%s"
>              % (VF_MAX_QUEUE, VF_MAX_QUEUE))
> -
> +
> +        output = self.vm0_testpmd.execute_cmd('show port info 0')
> +        vf_driver = re.findall("Driver\s*name:\s*(\w+)", output)
> +        if vf_driver[0] == "net_iavf":
> +            self.vm0_testpmd.execute_cmd('quit', '# ')
> +            self.vm0_testpmd.start_testpmd(VM_CORES_MASK,
> + "--port-topology=chained --txq=%s --rxq=%s --disable-rss" %
> + (VF_MAX_QUEUE, VF_MAX_QUEUE))

I think re-launch testpmd is a waste of time, prefer to start testpmd with 'disable-rss` directly.

> 
>      def destroy_vm_env(self):
> 
> --
> 2.17.1


      parent reply	other threads:[~2021-03-30  1:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-25 17:16 xiewei
2021-03-25  9:09 ` Xie, WeiX
2021-03-30  1:53 ` Tu, Lijuan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c10f7eb6a0a4815a40ebe443f4ed840@intel.com \
    --to=lijuan.tu@intel.com \
    --cc=dts@dpdk.org \
    --cc=weix.xie@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git