test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code
@ 2021-01-28  8:14 Hailin Xu
  2021-01-28  8:37 ` Xu, HailinX
  2021-02-02  8:55 ` Tu, Lijuan
  0 siblings, 2 replies; 4+ messages in thread
From: Hailin Xu @ 2021-01-28  8:14 UTC (permalink / raw)
  To: dts; +Cc: Hailin Xu

iavf/i40evf: Default RSS should be overwritten but not append after.

Signed-off-by: Hailin Xu <hailinx.xu@intel.com>
---
 tests/TestSuite_kernelpf_iavf.py | 35 +++++++++++---------------------
 1 file changed, 12 insertions(+), 23 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 2fed9b7f..1dcbc685 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -631,31 +631,20 @@ class TestKernelpfIavf(TestCase):
             self.verify(rx_err == 1 or tx_pkts == -1, "Packet drop assert error")
 
     def test_vf_rss(self):
+        rss_type = ["ip", "tcp", "udp"]
         self.vm_testpmd.start_testpmd("all", "--txq=4 --rxq=4")
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set verbose 1")
         for i, j in zip(list(range(64)), [0, 1, 2, 3]*16):
             self.vm_testpmd.execute_cmd("port config 0 rss reta (%d,%d)" % (i, j))
-        self.vm_testpmd.execute_cmd("port config all rss ip")
-        self.vm_testpmd.execute_cmd("port config all rss tcp")
-        self.vm_testpmd.execute_cmd("port config all rss udp")
-        self.vm_testpmd.execute_cmd("start")
-        self.send_packet(self.tester_intf, 'IPV4')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
-
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_packet(self.tester_intf, 'IPV4&TCP')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
-
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_packet(self.tester_intf, 'IPV4&UDP')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
+        for type in rss_type:
+            self.vm_testpmd.execute_cmd("port config all rss %s" % type)
+            self.vm_testpmd.execute_cmd("start")
+            self.send_packet(self.tester_intf, 'IPV4&%s' % type)
+            time.sleep(1)
+            out = self.vm_dut.get_session_output()
+            self.verify_packet_number(out)
+            self.vm_testpmd.execute_cmd("clear port stats all")
 
     def verify_packet_number(self, out):
         queue0_number = len(re.findall('port 0/queue 0', out))
@@ -672,21 +661,21 @@ class TestKernelpfIavf(TestCase):
         """
         mac = self.vf_mac
         # send packet with different source and dest ip
-        if tran_type == "IPV4":
+        if tran_type == "IPV4&ip":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", '\
                                   'dst="192.168.0.%d")], iface="%s")' % (mac, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
             self.tester.scapy_execute()
             time.sleep(.5)
-        elif tran_type == "IPV4&TCP":
+        elif tran_type == "IPV4&tcp":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/'\
                                   'TCP(sport=1024,dport=1024)], iface="%s")' % (mac, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
             self.tester.scapy_execute()
             time.sleep(.5)
-        elif tran_type == "IPV4&UDP":
+        elif tran_type == "IPV4&udp":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/'\
                                   'UDP(sport=1024,dport=1024)], iface="%s")' % (mac, i + 1, i + 2, itf)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code
  2021-01-28  8:14 [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code Hailin Xu
@ 2021-01-28  8:37 ` Xu, HailinX
  2021-02-02  8:55 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Xu, HailinX @ 2021-01-28  8:37 UTC (permalink / raw)
  To: Xu, HailinX, dts

[-- Attachment #1: Type: text/plain, Size: 321 bytes --]

Tested-by: Xu, HailinX <hailinx.xu@intel.com>

Regards,
Xu, Hailin

>-----Original Message-----
>From: Hailin Xu <hailinx.xu@intel.com> 
>Sent: Thursday, January 28, 2021 4:15 PM
>To: dts@dpdk.org
>Cc: Xu, HailinX <hailinx.xu@intel.com>
>Subject: [dts][PATCH v1] tests/kernelpf_iavf:align with dpdk rss code


[-- Attachment #2: TestKernelpfIavf.log --]
[-- Type: application/octet-stream, Size: 102004 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code
  2021-01-28  8:14 [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code Hailin Xu
  2021-01-28  8:37 ` Xu, HailinX
@ 2021-02-02  8:55 ` Tu, Lijuan
  1 sibling, 0 replies; 4+ messages in thread
From: Tu, Lijuan @ 2021-02-02  8:55 UTC (permalink / raw)
  To: Xu, HailinX, dts; +Cc: Xu, HailinX

> iavf/i40evf: Default RSS should be overwritten but not append after.
> 
> Signed-off-by: Hailin Xu <hailinx.xu@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code
@ 2021-01-28  7:51 Hailin Xu
  0 siblings, 0 replies; 4+ messages in thread
From: Hailin Xu @ 2021-01-28  7:51 UTC (permalink / raw)
  To: dts; +Cc: Hailin Xu

iavf/i40evf: Default RSS should be overwritten but not append after.

---
 tests/TestSuite_kernelpf_iavf.py | 35 +++++++++++---------------------
 1 file changed, 12 insertions(+), 23 deletions(-)

diff --git a/tests/TestSuite_kernelpf_iavf.py b/tests/TestSuite_kernelpf_iavf.py
index 2fed9b7f..1dcbc685 100644
--- a/tests/TestSuite_kernelpf_iavf.py
+++ b/tests/TestSuite_kernelpf_iavf.py
@@ -631,31 +631,20 @@ class TestKernelpfIavf(TestCase):
             self.verify(rx_err == 1 or tx_pkts == -1, "Packet drop assert error")
 
     def test_vf_rss(self):
+        rss_type = ["ip", "tcp", "udp"]
         self.vm_testpmd.start_testpmd("all", "--txq=4 --rxq=4")
         self.vm_testpmd.execute_cmd("set fwd mac")
         self.vm_testpmd.execute_cmd("set verbose 1")
         for i, j in zip(list(range(64)), [0, 1, 2, 3]*16):
             self.vm_testpmd.execute_cmd("port config 0 rss reta (%d,%d)" % (i, j))
-        self.vm_testpmd.execute_cmd("port config all rss ip")
-        self.vm_testpmd.execute_cmd("port config all rss tcp")
-        self.vm_testpmd.execute_cmd("port config all rss udp")
-        self.vm_testpmd.execute_cmd("start")
-        self.send_packet(self.tester_intf, 'IPV4')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
-
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_packet(self.tester_intf, 'IPV4&TCP')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
-
-        self.vm_testpmd.execute_cmd("clear port stats all")
-        self.send_packet(self.tester_intf, 'IPV4&UDP')
-        time.sleep(2)
-        out = self.vm_dut.get_session_output()
-        self.verify_packet_number(out)
+        for type in rss_type:
+            self.vm_testpmd.execute_cmd("port config all rss %s" % type)
+            self.vm_testpmd.execute_cmd("start")
+            self.send_packet(self.tester_intf, 'IPV4&%s' % type)
+            time.sleep(1)
+            out = self.vm_dut.get_session_output()
+            self.verify_packet_number(out)
+            self.vm_testpmd.execute_cmd("clear port stats all")
 
     def verify_packet_number(self, out):
         queue0_number = len(re.findall('port 0/queue 0', out))
@@ -672,21 +661,21 @@ class TestKernelpfIavf(TestCase):
         """
         mac = self.vf_mac
         # send packet with different source and dest ip
-        if tran_type == "IPV4":
+        if tran_type == "IPV4&ip":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", '\
                                   'dst="192.168.0.%d")], iface="%s")' % (mac, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
             self.tester.scapy_execute()
             time.sleep(.5)
-        elif tran_type == "IPV4&TCP":
+        elif tran_type == "IPV4&tcp":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/'\
                                   'TCP(sport=1024,dport=1024)], iface="%s")' % (mac, i + 1, i + 2, itf)
                 self.tester.scapy_append(packet)
             self.tester.scapy_execute()
             time.sleep(.5)
-        elif tran_type == "IPV4&UDP":
+        elif tran_type == "IPV4&udp":
             for i in range(30):
                 packet = r'sendp([Ether(dst="%s", src="02:00:00:00:00:00")/IP(src="192.168.0.%d", dst="192.168.0.%d")/'\
                                   'UDP(sport=1024,dport=1024)], iface="%s")' % (mac, i + 1, i + 2, itf)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-02  8:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-28  8:14 [dts] [PATCH v1] tests/kernelpf_iavf:align with dpdk rss code Hailin Xu
2021-01-28  8:37 ` Xu, HailinX
2021-02-02  8:55 ` Tu, Lijuan
  -- strict thread matches above, loose matches on Subject: below --
2021-01-28  7:51 Hailin Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).