test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy
  2021-05-06 16:19 [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy Bo Chen
@ 2021-05-06  8:18 ` Chen, BoX C
  2021-05-26  6:14   ` Tu, Lijuan
  0 siblings, 1 reply; 3+ messages in thread
From: Chen, BoX C @ 2021-05-06  8:18 UTC (permalink / raw)
  To: dts

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Tested-by: Bo Chen <box.c.chen@intel.com>

> -----Original Message-----
> From: Chen, BoX C <box.c.chen@intel.com>
> Sent: May 7, 2021 0:19
> To: dts@dpdk.org
> Cc: Chen, BoX C <box.c.chen@intel.com>
> Subject: [dts][PATCH V1] tests/pmdrss_hash: use flow api replace legancy
> 
> use flow api replace legancy filter command
> 
> Signed-off-by: Bo Chen <BoX.C.Chen@intel.com>


[-- Attachment #2: TestPmdrssHash.log --]
[-- Type: application/octet-stream, Size: 1073872 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy
@ 2021-05-06 16:19 Bo Chen
  2021-05-06  8:18 ` Chen, BoX C
  0 siblings, 1 reply; 3+ messages in thread
From: Bo Chen @ 2021-05-06 16:19 UTC (permalink / raw)
  To: dts; +Cc: Bo Chen

use flow api replace legancy filter command

Signed-off-by: Bo Chen <BoX.C.Chen@intel.com>
---
 tests/TestSuite_pmdrss_hash.py | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py
index fb83f78d..54c0a89d 100644
--- a/tests/TestSuite_pmdrss_hash.py
+++ b/tests/TestSuite_pmdrss_hash.py
@@ -390,7 +390,7 @@ class TestPmdrssHash(TestCase):
                 status = "true"
                 result.insert(i, 0)
                 if(i % 2 == 1):
-                    if(pre_RSS_hash == tmp_reta_line["RSS hash"]):
+                    if(pre_RSS_hash != tmp_reta_line["RSS hash"]):
                         status = "true"
                         result.insert(len(reta_lines) + (i - 1) // 2, 0)
                     else:
@@ -494,6 +494,7 @@ class TestPmdrssHash(TestCase):
         dutPorts = self.dut.get_ports(self.nic)
         localPort = self.tester.get_local_port(dutPorts[0])
         itf = self.tester.get_interface(localPort)
+        rule_action = 'func symmetric_toeplitz queues end / end'
         global reta_num
         global iptypes
 
@@ -512,10 +513,13 @@ class TestPmdrssHash(TestCase):
                 "set nbcore %d" % (queue + 1), "testpmd> ")
 
             self.dut.send_expect("port stop all", "testpmd> ")
-            self.dut.send_expect(
-                "set_hash_global_config 0 toeplitz %s enable" % iptype, "testpmd> ")
-            self.dut.send_expect(
-                "set_sym_hash_ena_per_port 0 enable", "testpmd> ")
+            self.dut.send_expect("flow flush 0", "testpmd> ")
+            rule_cmd = f'flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}'
+            if 'sctp' in iptype or 'udp' in iptype or 'tcp' in iptype:
+                rule_cmd = rule_cmd.replace('/ ipv4 /', f'/ ipv4 / {rsstype} /')
+            if 'ipv6' in iptype:
+                rule_cmd = rule_cmd.replace('ipv4', 'ipv6')
+            self.dut.send_expect(rule_cmd, "testpmd> ")
             self.dut.send_expect("port start all", "testpmd> ")
             out = self.dut.send_expect(
                 "port config all rss %s" % rsstype, "testpmd> ")
@@ -528,6 +532,7 @@ class TestPmdrssHash(TestCase):
                     "port config 0 rss reta (%d,%d)" % (i, reta_entries[i]), "testpmd> ")
 
             self.send_packet_symmetric(itf, iptype)
+            self.dut.send_expect("flow flush 0", "testpmd> ")
 
         self.dut.send_expect("quit", "# ", 30)
 
-- 
2.31.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy
  2021-05-06  8:18 ` Chen, BoX C
@ 2021-05-26  6:14   ` Tu, Lijuan
  0 siblings, 0 replies; 3+ messages in thread
From: Tu, Lijuan @ 2021-05-26  6:14 UTC (permalink / raw)
  To: Chen, BoX C, dts



> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Chen, BoX C
> Sent: 2021年5月6日 16:19
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy
> 
> Tested-by: Bo Chen <box.c.chen@intel.com>
> 
> > -----Original Message-----
> > From: Chen, BoX C <box.c.chen@intel.com>
> > Sent: May 7, 2021 0:19
> > To: dts@dpdk.org
> > Cc: Chen, BoX C <box.c.chen@intel.com>
> > Subject: [dts][PATCH V1] tests/pmdrss_hash: use flow api replace legancy
> >
> > use flow api replace legancy filter command
> >
> > Signed-off-by: Bo Chen <BoX.C.Chen@intel.com>

Applied


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-05-26  6:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-06 16:19 [dts] [PATCH V1] tests/pmdrss_hash: use flow api replace legancy Bo Chen
2021-05-06  8:18 ` Chen, BoX C
2021-05-26  6:14   ` Tu, Lijuan

test suite reviews and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dts/0 dts/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dts dts/ https://inbox.dpdk.org/dts \
		dts@dpdk.org
	public-inbox-index dts

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dts


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git