From: Rami Rosen <rami.rosen@huawei.com>
To: xuyanjie <yanjie.xu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] add execution new ipsec lib
Date: Tue, 16 Apr 2019 05:06:57 +0000 [thread overview]
Message-ID: <5151E1D101B7B04382075E3B0EF69373EBD468@lhreml503-mbs> (raw)
In-Reply-To: <1555401067-166916-1-git-send-email-yanjie.xu@intel.com>
Hi, Xuyanjie,
You have:
>+[Execution1]
>+crbs=10.67.110.186
>+drivername=igb_uio
If you will run from the executions folder:
git grep "crbs=" .
You will get:
execution.cfg:crbs=<CRB IP Address>
execution.cfg:crbs=<Performance CRB IP Address>
execution_FVL.cfg:crbs=<CRB IP Address>
execution_FVL.cfg:crbs=<Performance CRB IP Address>
execution_fm10k.cfg:crbs=<CRB IP Address>
execution_fm10k.cfg:crbs=<Performance CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_smoke.cfg:crbs=<CRB IP Address>
IMHO, there is no justification to an exception of having a specific IP address like
10.67.110.186, as in your patch, instead of having <CRB IP Address>, like all the others
execution files, as shown above.
Regards,
Rami Rosen
next prev parent reply other threads:[~2019-04-16 5:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-16 7:51 xuyanjie
2019-04-16 5:06 ` Rami Rosen [this message]
2019-04-16 17:22 ` Tu, Lijuan
2019-04-16 17:20 ` Tu, Lijuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5151E1D101B7B04382075E3B0EF69373EBD468@lhreml503-mbs \
--to=rami.rosen@huawei.com \
--cc=dts@dpdk.org \
--cc=yanjie.xu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).