Re: [dts] [PATCH] add execution new ipsec lib

Re: [dts] [PATCH] add execution new ipsec lib

[Rami Rosen]

Hi, Xuyanjie, 

You have: 
>+[Execution1]
>+crbs=10.67.110.186
>+drivername=igb_uio

If you will run from the executions folder:
git grep "crbs=" .

You will get:

execution.cfg:crbs=<CRB IP Address>
execution.cfg:crbs=<Performance CRB IP Address>
execution_FVL.cfg:crbs=<CRB IP Address>
execution_FVL.cfg:crbs=<Performance CRB IP Address>
execution_fm10k.cfg:crbs=<CRB IP Address>
execution_fm10k.cfg:crbs=<Performance CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_rxmode.cfg:crbs=<CRB IP Address>
execution_smoke.cfg:crbs=<CRB IP Address>

IMHO, there is no justification to an exception of having a specific IP address like
10.67.110.186, as in your patch, instead of having <CRB IP Address>, like all the others
execution files, as shown above.

Regards,
Rami Rosen

[dts] [PATCH] add execution new ipsec lib

[xuyanjie]

Signed-off-by: xuyanjie <yanjie.xu@intel.com>

diff --git a/conf/execution_cryptodev_new_ipsec-gw.cfg b/conf/execution_cryptodev_new_ipsec-gw.cfg
new file mode 100644
index 0000000..4bd719d
--- /dev/null
+++ b/conf/execution_cryptodev_new_ipsec-gw.cfg
@@ -0,0 +1,9 @@
+[Execution1]
+crbs=10.67.110.186
+drivername=igb_uio
+test_suites=
+    cryptodev_func_new_ipsec-gw
+targets=
+    x86_64-native-linuxapp-gcc
+parameters=nic_type=cfg:func=true
+
-- 
2.7.4

Re: [dts] [PATCH] add execution new ipsec lib

[Tu, Lijuan]

A new execution configuration file should contain a series of test suites of specific catalog.
It's a good idea to create an execution configuration file for cyptodev, but I think it should contain all the test suites of cyptodev.
For security consideration, do not have some sensitive info , such IP. Please reference to execution.cfg

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xuyanjie
> Sent: Tuesday, April 16, 2019 12:51 AM
> To: dts@dpdk.org
> Cc: Xu, Yanjie <yanjie.xu@intel.com>
> Subject: [dts] [PATCH] add execution new ipsec lib
> 
> Signed-off-by: xuyanjie <yanjie.xu@intel.com>
> 
> diff --git a/conf/execution_cryptodev_new_ipsec-gw.cfg
> b/conf/execution_cryptodev_new_ipsec-gw.cfg
> new file mode 100644
> index 0000000..4bd719d
> --- /dev/null
> +++ b/conf/execution_cryptodev_new_ipsec-gw.cfg
> @@ -0,0 +1,9 @@
> +[Execution1]
> +crbs=10.67.110.186
> +drivername=igb_uio
> +test_suites=
> +    cryptodev_func_new_ipsec-gw
> +targets=
> +    x86_64-native-linuxapp-gcc
> +parameters=nic_type=cfg:func=true
> +
> --
> 2.7.4

Re: [dts] [PATCH] add execution new ipsec lib

[Tu, Lijuan]

Agree with Rami

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Monday, April 15, 2019 10:07 PM
> To: Xu, Yanjie <yanjie.xu@intel.com>; dts@dpdk.org
> Subject: Re: [dts] [PATCH] add execution new ipsec lib
> 
> Hi, Xuyanjie,
> 
> You have:
> >+[Execution1]
> >+crbs=10.67.110.186
> >+drivername=igb_uio
> 
> If you will run from the executions folder:
> git grep "crbs=" .
> 
> You will get:
> 
> execution.cfg:crbs=<CRB IP Address>
> execution.cfg:crbs=<Performance CRB IP Address>
> execution_FVL.cfg:crbs=<CRB IP Address>
> execution_FVL.cfg:crbs=<Performance CRB IP Address>
> execution_fm10k.cfg:crbs=<CRB IP Address>
> execution_fm10k.cfg:crbs=<Performance CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_rxmode.cfg:crbs=<CRB IP Address>
> execution_smoke.cfg:crbs=<CRB IP Address>
> 
> IMHO, there is no justification to an exception of having a specific IP address
> like 10.67.110.186, as in your patch, instead of having <CRB IP Address>, like
> all the others execution files, as shown above.
> 
> Regards,
> Rami Rosen