test suite reviews and discussions
 help / color / mirror / Atom feed
* Re: [dts] [PATCH] dynamic add hardware requirement
  2019-04-18 13:51 [dts] [PATCH] dynamic add hardware requirement xuyanjie
@ 2019-04-18  8:18 ` Lin, Xueqin
  2019-04-18 10:32   ` Rami Rosen
  0 siblings, 1 reply; 3+ messages in thread
From: Lin, Xueqin @ 2019-04-18  8:18 UTC (permalink / raw)
  To: Xu, Yanjie, dts; +Cc: Xu, Yanjie

My comment as below.

Best regards,
Xueqin

> -----Original Message-----
> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of xuyanjie
> Sent: Thursday, April 18, 2019 9:51 PM
> To: dts@dpdk.org
> Cc: Xu, Yanjie <yanjie.xu@intel.com>
> Subject: [dts] [PATCH] dynamic add hardware requirement
> 
> Signed-off-by: xuyanjie <yanjie.xu@intel.com>
> 
> diff --git a/test_plans/dynamic_config_test_plan.rst
> b/test_plans/dynamic_config_test_plan.rst
> index 4b6b1c7..38a7e83 100644
> --- a/test_plans/dynamic_config_test_plan.rst
> +++ b/test_plans/dynamic_config_test_plan.rst
> @@ -51,6 +51,10 @@ When promiscuous mode is disabled, packet must not
> be received. When  it is enabled, packets must be received. The change
> occurs without  stopping the device or restarting the application.
> 
> +Hardware
> +=============
> +
> +Any type NIC is supported

[Xueqin] The scope is too large, in /dpdk/drivers/net path, there are so many driver types, we may test this suite on e1000, ixgbe, i40e, not try all especially not try on some not-intel NICs.
"Any type NIC" is not make sense.  

> 
>  Prerequisites
>  =============
> --
> 2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dts] [PATCH] dynamic add hardware requirement
  2019-04-18  8:18 ` Lin, Xueqin
@ 2019-04-18 10:32   ` Rami Rosen
  0 siblings, 0 replies; 3+ messages in thread
From: Rami Rosen @ 2019-04-18 10:32 UTC (permalink / raw)
  To: Lin, Xueqin, Xu, Yanjie, dts; +Cc: Xu, Yanjie

Hi,

>[Xueqin] The scope is too large, in /dpdk/drivers/net path, there are so many driver types, we may >test this suite on e1000, ixgbe, i40e, not try all especially not try on some not-intel NICs.
>"Any type NIC" is not make sense.  


+1 on this.

Actually, as of now, DTS supports nics from four vendors: Intel, Cavium Networks, Mellanox and Huawei (see framework/setting.py)

Regards,
Rami 


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [dts] [PATCH] dynamic add hardware requirement
@ 2019-04-18 13:51 xuyanjie
  2019-04-18  8:18 ` Lin, Xueqin
  0 siblings, 1 reply; 3+ messages in thread
From: xuyanjie @ 2019-04-18 13:51 UTC (permalink / raw)
  To: dts; +Cc: xuyanjie

Signed-off-by: xuyanjie <yanjie.xu@intel.com>

diff --git a/test_plans/dynamic_config_test_plan.rst b/test_plans/dynamic_config_test_plan.rst
index 4b6b1c7..38a7e83 100644
--- a/test_plans/dynamic_config_test_plan.rst
+++ b/test_plans/dynamic_config_test_plan.rst
@@ -51,6 +51,10 @@ When promiscuous mode is disabled, packet must not be received. When
 it is enabled, packets must be received. The change occurs without
 stopping the device or restarting the application.
 
+Hardware
+=============
+
+Any type NIC is supported
 
 Prerequisites
 =============
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-04-18 10:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-18 13:51 [dts] [PATCH] dynamic add hardware requirement xuyanjie
2019-04-18  8:18 ` Lin, Xueqin
2019-04-18 10:32   ` Rami Rosen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).