From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD48AA0C5A; Mon, 29 Nov 2021 04:40:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9E6C14068A; Mon, 29 Nov 2021 04:40:58 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 2BE5640689 for ; Mon, 29 Nov 2021 04:40:56 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10182"; a="235823587" X-IronPort-AV: E=Sophos;i="5.87,272,1631602800"; d="scan'208";a="235823587" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2021 19:40:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,272,1631602800"; d="scan'208";a="499164948" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga007.jf.intel.com with ESMTP; 28 Nov 2021 19:40:55 -0800 Received: from shsmsx604.ccr.corp.intel.com (10.109.6.214) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Sun, 28 Nov 2021 19:40:55 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX604.ccr.corp.intel.com (10.109.6.214) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 29 Nov 2021 11:40:53 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2308.020; Mon, 29 Nov 2021 11:40:53 +0800 From: "Tu, Lijuan" To: "Jiang, YuX" , "Yang, LeweiX" , "dts@dpdk.org" CC: "Yang, LeweiX" , "Lin, Xueqin" Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_ETH Thread-Topic: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_ETH Thread-Index: AQHXzu1n5/t3x7J2V0OKTtPugSp8NKwPzJFAgAB2nICACcRoAA== Date: Mon, 29 Nov 2021 03:40:53 +0000 Message-ID: <528cf3971c4642e5b4e17f903d1edda8@intel.com> References: <20211101152338.22226-1-leweix.yang@intel.com> <11c64c26058b4322ae2c02ebcab87ace@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.6.200.16 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org > -----Original Message----- > From: Jiang, YuX > Sent: 2021=1B$BG/=1B(B11=1B$B7n=1B(B23=1B$BF|=1B(B 14:30 > To: Tu, Lijuan ; Yang, LeweiX ; > dts@dpdk.org > Cc: Yang, LeweiX ; Lin, Xueqin > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to RTE_E= TH >=20 > > -----Original Message----- > > From: Tu, Lijuan > > Sent: Monday, November 22, 2021 11:27 PM > > To: Yang, LeweiX ; dts@dpdk.org > > Cc: Yang, LeweiX > > Subject: RE: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > > RTE_ETH > > > > > > > > > -----Original Message----- > > > From: dts On Behalf Of Lewei Yang > > > Sent: 2021=1B$BG/=1B(B11=1B$B7n=1B(B1=1B$BF|=1B(B 23:24 > > > To: dts@dpdk.org > > > Cc: Yang, LeweiX > > > Subject: [dts] [PATCH V1] tests/userspace_ethtool:rename ETH to > > > RTE_ETH > > > > > > From: YangLewei > > > > > > According to dpdk commit 295968d17407("ethdev: add namespace"), > > rename > > > ETH to RTE_ETH > > > > > > Signed-off-by: YangLewei > > > --- > > > test_plans/userspace_ethtool_test_plan.rst | 2 +- > > > tests/TestSuite_userspace_ethtool.py | 2 +- > > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/test_plans/userspace_ethtool_test_plan.rst > > > b/test_plans/userspace_ethtool_test_plan.rst > > > index ca86beaf..9dca4b49 100644 > > > --- a/test_plans/userspace_ethtool_test_plan.rst > > > +++ b/test_plans/userspace_ethtool_test_plan.rst > > > @@ -164,7 +164,7 @@ Test Case: Vlan test > > > > > > enable vlan filter flag in main.c of dpdk's ethtool:: > > > > > > - sed -i -e '/cfg_port.txmode.mq_mode =3D > > > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=3DDEV_RX_OFFLOAD_VL > > AN > > > _FILTER;' examples/ethtool/ethtool-app/main.c > > > + sed -i -e '/cfg_port.txmode.mq_mode =3D > > > + > > > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=3DDEV_RX_OFFLOA > > D_ > > > VLAN_ > > > + FILTER;' examples/ethtool/ethtool-app/main.c > > > > > > re-compile examples/ethtool:: > > > > > > diff --git a/tests/TestSuite_userspace_ethtool.py > > > b/tests/TestSuite_userspace_ethtool.py > > > index 4536b7d1..8fae4f2c 100644 > > > --- a/tests/TestSuite_userspace_ethtool.py > > > +++ b/tests/TestSuite_userspace_ethtool.py > > > @@ -449,7 +449,7 @@ class TestUserspaceEthtool(TestCase): > > > """ > > > main_file =3D "examples/ethtool/ethtool-app/main.c" > > > # enable vlan filter > > > - self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = =3D > > > > > ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=3DDEV_RX_OFFLOAD_VL > > AN > > > _FILTER;' %s" % main_file, "# ") > > > + self.dut.send_expect("sed -i -e '/cfg_port.txmode.mq_mode = =3D > > > + > > > > > RTE_ETH_MQ_TX_NONE;$/a\\cfg_port.rxmode.offloads|=3DDEV_RX_OFFLOA > > D_ > > > VLAN_ > > > + FILTER;' %s" % main_file, "# ") > > > > Can we test the point and don't modify DPDK. > > > If we do not modify DPDK code, it tests failed. More details see the atta= ched. > Port 0: VLAN-filtering disabled > Port 0: VLAN filtering disabled > Test Case test_ethtool_vlan Result FAILED: 'Failed to filter Rx vlan pack= et' If vlan do need be tested, request DPDK to add the code is more reasonable. >=20 > > > > > > # build sample app > > > self.build_ethtool() > > > -- > > > 2.33.1 >=20