From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id D0CE03237
 for <dts@dpdk.org>; Tue, 26 May 2015 11:11:24 +0200 (CEST)
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
 by orsmga102.jf.intel.com with ESMTP; 26 May 2015 02:11:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.13,497,1427785200"; d="scan'208";a="715597837"
Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78])
 by fmsmga001.fm.intel.com with ESMTP; 26 May 2015 02:11:21 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS)
 id 14.3.224.2; Tue, 26 May 2015 17:08:37 +0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.120]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.109]) with mapi id 14.03.0224.002;
 Tue, 26 May 2015 17:07:04 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Jiajia, SunX" <sunx.jiajia@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Thread-Topic: [dts] [PATCH v2 05/19] Add a module to instantiate the VM
Thread-Index: AQHQlG5Y94MyDweWsUuuhuMPNyQ7Xw==
Date: Tue, 26 May 2015 09:07:03 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E60286046816DE@SHSMSX101.ccr.corp.intel.com>
References: <1432285452-14286-1-git-send-email-sunx.jiajia@intel.com>
 <1432285452-14286-6-git-send-email-sunx.jiajia@intel.com>
 <533710CFB86FA344BFBF2D6802E6028604680F0A@SHSMSX101.ccr.corp.intel.com>
 <F21F274FCF2C0948830A3ED00345297734DD8D@SHSMSX104.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 26 May 2015 09:11:25 -0000

On 5/25/2015 5:14 PM, Jiajia, SunX wrote:=0A=
> Hi Michael,=0A=
>=0A=
> Please see the comments below.=0A=
>=0A=
>> -----Original Message-----=0A=
>> From: Qiu, Michael=0A=
>> Sent: Monday, May 25, 2015 2:11 PM=0A=
>> To: Jiajia, SunX; dts@dpdk.org=0A=
>> Subject: Re: [dts] [PATCH v2 05/19] Add a module to instantiate the VM=
=0A=
>>=0A=
>> On 5/22/2015 5:04 PM, Jiajia, Sun wrote:=0A=
>>> From: sjiajiax <sunx.jiajia@intel.com>=0A=
=0A=
...=0A=
=0A=
>>> +        return 1=0A=
>>> +=0A=
>>> +    def check_ports_available(self, pci_bus, pci_id):=0A=
>>> +        """=0A=
>>> +        Check that whether auto scanned ports ready to use=0A=
>>> +        """=0A=
>>> +        pci_addr =3D "%s:%s" % (pci_bus, pci_id)=0A=
>>> +        if pci_id =3D=3D "8086:100e":=0A=
>>> +            return False=0A=
>> Why here return false? better to give some comments.=0A=
>>=0A=
>> Also pci_id here should be pci_addr I think.=0A=
> Because the e1000 network is commonly the control port for tester,=0A=
> So it will be ignored defaultly.=0A=
=0A=
Does pci_addr needed here? It do nothing.=0A=
=0A=
Thanks,=0A=
Michael=0A=
>=0A=
>>> +        return True=0A=
>>> +=0A=
>>> +    def scan_ports(self):=0A=
>>> +        """=0A=
>>> +        Scan ports information, for vm will always scan=0A=
>>> +        """=0A=
>>> +        self.scan_ports_uncached()=0A=
>>> +=0A=
>>> +    def scan_ports_uncached(self):=0A=
>>> +        """=0A=
>>> +        Scan ports and collect port's pci id, mac adress, ipv6=0A=
>>=0A=
>=0A=
=0A=