From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 16DA05A58 for ; Wed, 8 Jul 2015 03:51:01 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP; 07 Jul 2015 18:51:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,428,1432623600"; d="scan'208";a="760227929" Received: from pgsmsx101.gar.corp.intel.com ([10.221.44.78]) by orsmga002.jf.intel.com with ESMTP; 07 Jul 2015 18:51:00 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by PGSMSX101.gar.corp.intel.com (10.221.44.78) with Microsoft SMTP Server (TLS) id 14.3.224.2; Wed, 8 Jul 2015 09:49:40 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.246]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.168]) with mapi id 14.03.0224.002; Wed, 8 Jul 2015 09:49:39 +0800 From: "Qiu, Michael" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter Thread-Index: AQHQuJilKmVAnAG7N0SawqYf/r1msw== Date: Wed, 8 Jul 2015 01:49:38 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286046B212C@SHSMSX101.ccr.corp.intel.com> References: <1436261880-22395-1-git-send-email-michael.qiu@intel.com> <1436261880-22395-3-git-send-email-michael.qiu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10E5AD6A@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 01:51:02 -0000 On 7/8/2015 8:57 AM, Liu, Yong wrote:=0A= > Michael,=0A= > Look like scatter feature only validated on Niantic, Fortville, RRC these= three types of card.=0A= > We can check NIC type in set_up_all function and not need these duplicate= d checking code. =0A= =0A= It make sense, I will rework for V2=0A= =0A= Thanks,=0A= Michael=0A= >=0A= >> -----Original Message-----=0A= >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu=0A= >> Sent: Tuesday, July 07, 2015 5:38 PM=0A= >> To: dts@dpdk.org=0A= >> Subject: [dts] [PATCH 2/3] tests: Add RRC support in suit scatter=0A= >>=0A= >> Add RRC support in suit scatter=0A= >>=0A= >> Signed-off-by: Michael Qiu =0A= >> ---=0A= >> tests/TestSuite_scatter.py | 15 ++++++++-------=0A= >> 1 file changed, 8 insertions(+), 7 deletions(-)=0A= >>=0A= >> diff --git a/tests/TestSuite_scatter.py b/tests/TestSuite_scatter.py=0A= >> index 643fe4a..130898f 100644=0A= >> --- a/tests/TestSuite_scatter.py=0A= >> +++ b/tests/TestSuite_scatter.py=0A= >> @@ -62,10 +62,11 @@ class TestScatter(TestCase):=0A= >> """=0A= >> sport =3D self.tester.get_local_port(sPortid)=0A= >> sintf =3D self.tester.get_interface(sport)=0A= >> - smac =3D self.dut.get_mac_address(sPortid)=0A= >> + smac =3D self.tester.get_mac(sport)=0A= >> + dmac =3D self.dut.get_mac_address(sPortid)=0A= >> rport =3D self.tester.get_local_port(rPortid)=0A= >> rintf =3D self.tester.get_interface(rport)=0A= >> - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single"]:=0A= >> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single", "redrockcanyou"]:=0A= >> self.tester.send_expect("ifconfig %s mtu 9000" % sintf, "#"= )=0A= >> self.tester.send_expect("ifconfig %s mtu 9000" % rintf, "#"= )=0A= >>=0A= >> @@ -79,10 +80,10 @@ class TestScatter(TestCase):=0A= >>=0A= >> self.tester.scapy_foreground()=0A= >> self.tester.scapy_append(=0A= >> - 'sendp([Ether(dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s= )],=0A= >> iface=3D"%s")' % (smac, pktlen, padding, sintf))=0A= >> +=0A= >> 'sendp([Ether(src=3D"%s",dst=3D"%s")/IP(len=3D%s)/Raw(load=3D"\x50"*%s)]= ,=0A= >> iface=3D"%s")' % (smac, dmac,pktlen, padding, sintf))=0A= >> self.tester.scapy_execute()=0A= >> res =3D self.tester.scapy_get_result()=0A= >> - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single"]:=0A= >> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single", "redrockcanyou"]:=0A= >> self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#"= )=0A= >> self.tester.send_expect("ifconfig %s mtu 1500" % sintf, "#"= )=0A= >> return res=0A= >> @@ -103,7 +104,7 @@ class TestScatter(TestCase):=0A= >> portMask =3D dts.create_mask(dutPorts[:2])=0A= >>=0A= >> # set the mbuf size to 1024=0A= >> - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single"]:=0A= >> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single", "redrockcanyou"]:=0A= >> out =3D self.pmdout.start_testpmd(=0A= >> "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D2048 --portm= ask=3D%s=0A= >> --max-pkt-len=3D9000" % portMask)=0A= >> else:=0A= >> @@ -111,12 +112,12 @@ class TestScatter(TestCase):=0A= >> "1S/2C/2T", "--mbcache=3D200 --mbuf-size=3D1024 --=0A= >> portmask=3D%s" % portMask)=0A= >> self.verify("Error" not in out, "launch error 1")=0A= >>=0A= >> - if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single"]:=0A= >> + if self.nic in ["niantic", "fortville_eagle", "fortville_spirit= ",=0A= >> "fortville_spirit_single", "redrockcanyou"]:=0A= >> self.dut.send_expect("set fwd mac", "testpmd> ", 120)=0A= >> self.dut.send_expect("start", "testpmd> ")=0A= >>=0A= >> for offset in [-1, 0, 1, 4, 5]:=0A= >> - if self.nic in ["niantic", "fortville_eagle",=0A= >> "fortville_spirit", "fortville_spirit_single"]:=0A= >> + if self.nic in ["niantic", "fortville_eagle",=0A= >> "fortville_spirit", "fortville_spirit_single", "redrockcanyou"]:=0A= >> ret =3D self.scatter_pktgen_send_packet(=0A= >> dutPorts[0], dutPorts[1], 2048 + offset)=0A= >> else:=0A= >> --=0A= >> 1.9.3=0A= >=0A= =0A=