test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>,
	"Liu, Yong" <yong.liu@intel.com>,  "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] Add RRC support for shutdown_api
Date: Tue, 20 Oct 2015 08:14:05 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B4DF98@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <DF2A19295B96364286FEB7F3DDA27A4637A90A9B@SHSMSX101.ccr.corp.intel.com>

On 2015/10/20 10:34, Xu, HuilongX wrote:
> Hi Michael,
> Pls see my comments as below.
> Thanks  a lot
>>

[../..]

>> self.tester.scapy_append('sendp([Ether(dst="%s")/Dot1Q(vlan=1)/IP()/Raw(lo
>> ad="\x50"*%s)], iface="%s")' % (mac, padding, itf))
>>> +            if pktSize <= 64:
>>> +                pktSize=68
> Why pktsize minimum is 68, RRC nic minimum pktsize is 68?

Not yet, because one vlan packet is 68 bytes right?

Thanks,
Michael

[../..]

>>>      def test_change_linkspeed(self):
>>>          """
>>>          Change Link Speed.
>>>          """
>>> +        if self.nic == "redrockcanyou":
>>> +            print dts.RED("RRC not support\n")
>>> +            return
>>> +
> You shoud add this case in check_case_list.xlsx for skip RRC test.

I will add it in other patch.


>>>          self.pmdout.start_testpmd("Default", "--portmask=%s" %
>> dts.create_mask(self.ports), socket=self.ports_socket)
>>>
>


      parent reply	other threads:[~2015-10-20  8:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-15  3:08 Michael Qiu
     [not found] ` <533710CFB86FA344BFBF2D6802E6028621B4D839@SHSMSX101.ccr.corp.intel.com>
     [not found]   ` <DF2A19295B96364286FEB7F3DDA27A4637A90A9B@SHSMSX101.ccr.corp.intel.com>
2015-10-20  8:14     ` Qiu, Michael [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E6028621B4DF98@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=dts@dpdk.org \
    --cc=huilongx.xu@intel.com \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).