From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <michael.qiu@intel.com>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id E228291B0
 for <dts@dpdk.org>; Tue, 20 Oct 2015 10:14:09 +0200 (CEST)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga103.fm.intel.com with ESMTP; 20 Oct 2015 01:14:08 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.17,706,1437462000"; d="scan'208";a="667856640"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
 by orsmga003.jf.intel.com with ESMTP; 20 Oct 2015 01:14:08 -0700
Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.248.2; Tue, 20 Oct 2015 01:14:07 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.96]) by
 SHSMSX103.ccr.corp.intel.com ([169.254.4.204]) with mapi id 14.03.0248.002;
 Tue, 20 Oct 2015 16:14:06 +0800
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Xu, HuilongX" <huilongx.xu@intel.com>, "Liu, Yong" <yong.liu@intel.com>, 
 "dts@dpdk.org" <dts@dpdk.org>
Thread-Topic: [PATCH] Add RRC support for shutdown_api
Thread-Index: AQHQvquSSDaYUUVjY0aQkyrdf4kCmg==
Date: Tue, 20 Oct 2015 08:14:05 +0000
Message-ID: <533710CFB86FA344BFBF2D6802E6028621B4DF98@SHSMSX101.ccr.corp.intel.com>
References: <1436929716-15458-1-git-send-email-michael.qiu@intel.com>
 <533710CFB86FA344BFBF2D6802E6028621B4D839@SHSMSX101.ccr.corp.intel.com>
 <DF2A19295B96364286FEB7F3DDA27A4637A90A9B@SHSMSX101.ccr.corp.intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dts] [PATCH] Add RRC support for shutdown_api
X-BeenThere: dts@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: test suite reviews and discussions <dts.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dts>,
 <mailto:dts-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dts/>
List-Post: <mailto:dts@dpdk.org>
List-Help: <mailto:dts-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dts>,
 <mailto:dts-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2015 08:14:10 -0000

On 2015/10/20 10:34, Xu, HuilongX wrote:=0A=
> Hi Michael,=0A=
> Pls see my comments as below.=0A=
> Thanks  a lot=0A=
>>=0A=
=0A=
[../..]=0A=
=0A=
>> self.tester.scapy_append('sendp([Ether(dst=3D"%s")/Dot1Q(vlan=3D1)/IP()/=
Raw(lo=0A=
>> ad=3D"\x50"*%s)], iface=3D"%s")' % (mac, padding, itf))=0A=
>>> +            if pktSize <=3D 64:=0A=
>>> +                pktSize=3D68=0A=
> Why pktsize minimum is 68, RRC nic minimum pktsize is 68?=0A=
=0A=
Not yet, because one vlan packet is 68 bytes right?=0A=
=0A=
Thanks,=0A=
Michael=0A=
=0A=
[../..]=0A=
=0A=
>>>      def test_change_linkspeed(self):=0A=
>>>          """=0A=
>>>          Change Link Speed.=0A=
>>>          """=0A=
>>> +        if self.nic =3D=3D "redrockcanyou":=0A=
>>> +            print dts.RED("RRC not support\n")=0A=
>>> +            return=0A=
>>> +=0A=
> You shoud add this case in check_case_list.xlsx for skip RRC test.=0A=
=0A=
I will add it in other patch.=0A=
=0A=
=0A=
>>>          self.pmdout.start_testpmd("Default", "--portmask=3D%s" %=0A=
>> dts.create_mask(self.ports), socket=3Dself.ports_socket)=0A=
>>>=0A=
>=0A=
=0A=