From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 2AAEA8E80 for ; Wed, 4 Nov 2015 06:45:26 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 03 Nov 2015 21:45:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,241,1444719600"; d="scan'208";a="842659038" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga002.fm.intel.com with ESMTP; 03 Nov 2015 21:45:25 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 21:45:24 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.57]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.56]) with mapi id 14.03.0248.002; Wed, 4 Nov 2015 13:45:17 +0800 From: "Qiu, Michael" To: "Liu, Yong" , "dts@dpdk.org" Thread-Topic: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC Thread-Index: AQHRBi6dUA1l8KdGL0eEHnQ051djkg== Date: Wed, 4 Nov 2015 05:45:16 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028621B6571C@SHSMSX101.ccr.corp.intel.com> References: <1444792509-19136-1-git-send-email-michael.qiu@intel.com> <86228AFD5BCD8E4EBFD2B90117B5E81E10F2AE87@SHSMSX103.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 05:45:26 -0000 Hi, Marvin=0A= =0A= Just as I said in other thread, I will make a patch to update the list.=0A= =0A= And what about this patch?=0A= =0A= Thanks,=0A= Michael=0A= =0A= On 2015/10/14 18:19, Liu, Yong wrote:=0A= > Hi Michael,=0A= > Same comment, we have excel file tracking those features what we do not s= upport.=0A= > For the RRC Testpoint, I think we need implement one structure for this. = We cannot reply on manual commands to run DTS.=0A= >=0A= >> -----Original Message-----=0A= >> From: dts [mailto:dts-bounces@dpdk.org] On Behalf Of Michael Qiu=0A= >> Sent: Wednesday, October 14, 2015 4:15 AM=0A= >> To: dts@dpdk.org=0A= >> Subject: [dts] [PATCH] jumboframes: Fix bug for fm10k NIC=0A= >>=0A= >> For Ruby Rapid, in Testpoint should run "set port config 1,5=0A= >> max_frame_size 9000"=0A= >> and "set port config 1,5,20,22 rx_cut_through off"=0A= >>=0A= >> Singed-off-by: Michael Qiu =0A= >> ---=0A= >> tests/TestSuite_jumboframes.py | 12 ++++++++----=0A= >> 1 file changed, 8 insertions(+), 4 deletions(-)=0A= >>=0A= >> diff --git a/tests/TestSuite_jumboframes.py=0A= >> b/tests/TestSuite_jumboframes.py=0A= >> index c5c70b9..e9a6abf 100644=0A= >> --- a/tests/TestSuite_jumboframes.py=0A= >> +++ b/tests/TestSuite_jumboframes.py=0A= >> @@ -93,7 +93,9 @@ class TestJumboframes(TestCase):=0A= >> p1rx_err -=3D gp1rx_err=0A= >>=0A= >> if received:=0A= >> - self.verify(p0tx_pkts =3D=3D p1rx_pkts and p0tx_bytes =3D= =3D pktsize=0A= >> and p1rx_bytes =3D=3D pktsize,=0A= >> + #some nic like RRC always strip CRC, so it should be pktsiz= e=0A= >> - 4=0A= >> + size_equal =3D p0tx_bytes =3D=3D p1rx_bytes and (p1rx_bytes= =3D=3D=0A= >> pktsize or p1rx_bytes =3D=3D pktsize - 4)=0A= >> + self.verify(p0tx_pkts =3D=3D p1rx_pkts and size_equal,=0A= >> "packet pass assert error")=0A= >> else:=0A= >> #self.verify(p0tx_pkts =3D=3D p1rx_pkts and (p1rx_err =3D= =3D 1 or=0A= >> p1rx_pkts =3D=3D 0),=0A= >> @@ -152,10 +154,12 @@ class TestJumboframes(TestCase):=0A= >> This case aims to test transmitting jumbo frame packet on testp= md=0A= >> without=0A= >> jumbo frame support.=0A= >> """=0A= >> - self.pmdout.start_testpmd("Default", "--max-pkt-len=3D%d" %=0A= >> (ETHER_STANDARD_MTU))=0A= >> + # RRC has no ability to set the max pkt len to hardware=0A= >> if self.nic =3D=3D "redrockcanyou":=0A= >> - self.dut.send_expect("set promisc all off", "testpmd> ")=0A= >> - self.dut.send_expect("set fwd mac", "testpmd> ")=0A= >> + print dts.RED("fm10k not support this case\n")=0A= >> + return=0A= >> + self.pmdout.start_testpmd("Default", "--max-pkt-len=3D%d" %=0A= >> (ETHER_STANDARD_MTU))=0A= >> + self.dut.send_expect("set fwd mac", "testpmd> ")=0A= >> self.dut.send_expect("start", "testpmd> ")=0A= >>=0A= >> self.jumboframes_send_packet(ETHER_STANDARD_MTU + 1, False)=0A= >> --=0A= >> 1.9.3=0A= >=0A= =0A=