Re: [dts] [PATCH] queue start/stop case failed

["Qiu, Michael" <michael.qiu@intel.com>]

Yes.

In commit log, we should add more details about this patch, to tell
reviewers why and what you do.

If it is a bug fix, you need to declare the root cause of the bug,
better to show how to solve it.

It is very important for you and reviewers to know what things are going
on now :) instead of go through your code.

Thanks,
Michael

On 2015/10/23 14:58, Liu, Yong wrote:
> Huilong,
> Please modify your commit log, it can't show what has been changed in 
> your patch.
>
> On 10/23/2015 02:39 PM, xu,huilong wrote:
>> Signed-off-by: xu,huilong <huilongx.xu@intel.com>
>> ---
>>   tests/TestSuite_queue_start_stop.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue_start_stop.py
>> index 83504ab..f59333c 100644
>> --- a/tests/TestSuite_queue_start_stop.py
>> +++ b/tests/TestSuite_queue_start_stop.py
>> @@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):
>>               self.dut.send_expect("port 1 txq 0 stop", "testpmd>")
>>               self.dut.send_expect("start", "testpmd>")
>>               self.check_forwarding([0, 1], self.nic, received=False)
>> -            out = self.dut.send_expect("\n", "testpmd>")
>> +            out = self.dut.get_session_output()
>>           except Exception, e:
>>               raise IOError("queue start/stop forward failure: %s" % e)
>>   
>