From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 1270D8E80 for ; Wed, 4 Nov 2015 06:51:55 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP; 03 Nov 2015 21:51:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,241,1444719600"; d="scan'208";a="826474722" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga001.fm.intel.com with ESMTP; 03 Nov 2015 21:51:42 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 21:51:41 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 3 Nov 2015 21:51:41 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.57]) by shsmsx102.ccr.corp.intel.com ([169.254.2.199]) with mapi id 14.03.0248.002; Wed, 4 Nov 2015 13:51:39 +0800 From: "Qiu, Michael" To: "Liu, Yong" , "Xu, HuilongX" , "dts@dpdk.org" , NPG-PRC-SW STV , NPG-PRC-SW STV CW Thread-Topic: [dts] [PATCH] queue start/stop case failed Thread-Index: AQHRDV5RJilX/CgPDEmkdg4f5aI7Vw== Date: Wed, 4 Nov 2015 05:51:38 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E6028621B65772@SHSMSX101.ccr.corp.intel.com> References: <1445582392-41627-1-git-send-email-huilongx.xu@intel.com> <5629DB1F.3040107@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] queue start/stop case failed X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Nov 2015 05:51:56 -0000 Yes.=0A= =0A= In commit log, we should add more details about this patch, to tell=0A= reviewers why and what you do.=0A= =0A= If it is a bug fix, you need to declare the root cause of the bug,=0A= better to show how to solve it.=0A= =0A= It is very important for you and reviewers to know what things are going=0A= on now :) instead of go through your code.=0A= =0A= Thanks,=0A= Michael=0A= =0A= On 2015/10/23 14:58, Liu, Yong wrote:=0A= > Huilong,=0A= > Please modify your commit log, it can't show what has been changed in =0A= > your patch.=0A= >=0A= > On 10/23/2015 02:39 PM, xu,huilong wrote:=0A= >> Signed-off-by: xu,huilong =0A= >> ---=0A= >> tests/TestSuite_queue_start_stop.py | 2 +-=0A= >> 1 file changed, 1 insertion(+), 1 deletion(-)=0A= >>=0A= >> diff --git a/tests/TestSuite_queue_start_stop.py b/tests/TestSuite_queue= _start_stop.py=0A= >> index 83504ab..f59333c 100644=0A= >> --- a/tests/TestSuite_queue_start_stop.py=0A= >> +++ b/tests/TestSuite_queue_start_stop.py=0A= >> @@ -164,7 +164,7 @@ class TestQueueStartStop(TestCase):=0A= >> self.dut.send_expect("port 1 txq 0 stop", "testpmd>")=0A= >> self.dut.send_expect("start", "testpmd>")=0A= >> self.check_forwarding([0, 1], self.nic, received=3DFalse)= =0A= >> - out =3D self.dut.send_expect("\n", "testpmd>")=0A= >> + out =3D self.dut.get_session_output()=0A= >> except Exception, e:=0A= >> raise IOError("queue start/stop forward failure: %s" % e)= =0A= >> =0A= >=0A= =0A=