From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: DUT and Tester coexisted in the same platform
Date: Mon, 26 Jan 2015 05:09:49 +0000 [thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CBA37F@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1422247975-30646-1-git-send-email-yong.liu@intel.com>
On 1/26/2015 12:53 PM, Yong Liu wrote:
> This patch based on "[PATCH 0/4] Support additional port configuration file".
> And do not support to run softwore performance test in the same platform.
>
> Fix one bug in pci numa parse.
>
> Signed-off-by: Marvinliu <yong.liu@intel.com>
> ---
> framework/config.py | 5 ++++-
> framework/tester.py | 5 ++++-
> 2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/framework/config.py b/framework/config.py
> index 140c84b..948609a 100755
> --- a/framework/config.py
> +++ b/framework/config.py
> @@ -79,7 +79,10 @@ class UserConf():
>
> for param in port.split(','):
> (key, _, value) = param.partition('=')
> - portDict[key] = value
> + if key == 'numa':
> + portDict[key] = int(value)
> + else:
> + portDict[key] = value
> return portDict
>
>
Better to make another patch for this issue.
Thanks,
Michael
> diff --git a/framework/tester.py b/framework/tester.py
> index 345ab41..b35a359 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -287,6 +287,10 @@ class Tester(Crb):
> if hits[localPort]:
> continue
>
> + # skip ping self port
> + if (self.crb['IP'] == self.crb['tester IP']) and (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
> + continue
> +
> ipv6 = self.dut.get_ipv6_address(dutPort)
> if ipv6 == "Not connected":
> continue
> @@ -440,7 +444,6 @@ class Tester(Crb):
> """
> if not self.has_external_traffic_generator():
> self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
> - super(Tester, self).kill_all()
>
> def close(self):
> """
next prev parent reply other threads:[~2015-01-26 5:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-26 4:52 Yong Liu
2015-01-26 5:03 ` Qiu, Michael
2015-01-26 5:09 ` Qiu, Michael [this message]
2015-01-26 5:12 ` Liu, Yong
2015-01-27 2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
2015-02-04 3:18 ` Qiu, Michael
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533710CFB86FA344BFBF2D6802E60286CBA37F@SHSMSX101.ccr.corp.intel.com \
--to=michael.qiu@intel.com \
--cc=dts@dpdk.org \
--cc=yong.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).