From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C700B5F13 for ; Tue, 27 Jan 2015 09:46:13 +0100 (CET) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP; 27 Jan 2015 00:40:07 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,473,1418112000"; d="scan'208";a="668185724" Received: from kmsmsx153.gar.corp.intel.com ([172.21.73.88]) by fmsmga002.fm.intel.com with ESMTP; 27 Jan 2015 00:46:03 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by KMSMSX153.gar.corp.intel.com (172.21.73.88) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 27 Jan 2015 16:46:02 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.64]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.129]) with mapi id 14.03.0195.001; Tue, 27 Jan 2015 16:46:00 +0800 From: "Qiu, Michael" To: "Xu, HuilongX" , "dts@dpdk.org" Thread-Topic: [dts] [ PATCH V2] update framework for support fortville NIC test. Thread-Index: AQHQOfW0ZuVQzNnNUkmcGoGY4ZA77A== Date: Tue, 27 Jan 2015 08:46:00 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CBAC40@SHSMSX101.ccr.corp.intel.com> References: <1422338041-14532-1-git-send-email-huilongx.xu@intel.com> <533710CFB86FA344BFBF2D6802E60286CBAAD6@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [ PATCH V2] update framework for support fortville NIC test. X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jan 2015 08:46:14 -0000 On 1/27/2015 2:53 PM, Xu, HuilongX wrote:=0A= > Hi Michael,=0A= > Thanks a lot for your comments.=0A= > You can check my V2 patch.=0A= >=0A= >> + elif pci_id in ('8086:1583','8086:1584','8086:1572'):= =0A= >> + if not os.path.exists("/sys/bus/pci/drivers/i40e/"+= "0000:"+pci_bus):=0A= > This code is only support check the driver in tester, can=92t check dut, = so it=92s a bug for check the driver status.=0A= > Maybe we can send a new patch for fix check driver stats. It need includ= e all driver eg, ixgeb, igb,i40e,e1000...=0A= >=0A= > Thanks a lot=0A= >=0A= > -----Original Message-----=0A= > From: Qiu, Michael =0A= > Sent: Tuesday, January 27, 2015 2:41 PM=0A= > To: Xu, HuilongX; dts@dpdk.org=0A= > Subject: Re: [dts] [ PATCH V2] update framework for support fortville NIC= test.=0A= >=0A= > Hi, huilong=0A= >=0A= > Have you seen my comments with your v1 patch?=0A= >=0A= > Also you'd better to make update patch within the original thread.=0A= >=0A= > Thanks,=0A= > Michael=0A= > On 1/27/2015 1:54 PM, huilongx.xu wrote:=0A= >> execution_fortville.cfg is the test case list for fortville NIC=0A= >>=0A= >> crb.py, add fortville NIC kernel driver(i40e) in dts=0A= >>=0A= >> settings.py, add fortville NIC info in dts=0A= >>=0A= >> test_case.py, insmod and used i40e for fortvill NIC=0A= >>=0A= >> Signed-off-by: huilongx.xu =0A= >> ---=0A= >> execution_fortville.cfg | 21 +++++++++++++++++++++=0A= >> framework/crb.py | 9 ++++++++-=0A= >> framework/settings.py | 6 ++++++=0A= >> framework/test_case.py | 4 ++++=0A= >> 4 files changed, 39 insertions(+), 1 deletions(-)=0A= >> create mode 100644 execution_fortville.cfg=0A= >>=0A= >> diff --git a/execution_fortville.cfg b/execution_fortville.cfg=0A= >> new file mode 100644=0A= >> index 0000000..15f2ccf=0A= >> --- /dev/null=0A= >> +++ b/execution_fortville.cfg=0A= >> @@ -0,0 +1,21 @@=0A= >> +[Execution1]=0A= >> +crbs=3D=0A= >> +drivername=3D=0A= >> +test_suites=3D=0A= >> + cmdline,=0A= >> + hello_world,=0A= >> + multiprocess,=0A= >> + blacklist=0A= >> +targets=3D=0A= >> + x86_64-native-linuxapp-gcc=0A= >> +parameters=3Dnic_type=3Dfortville_eagle:func=3Dtrue=0A= >> +=0A= >> +[Execution2]=0A= >> +crbs=3D=0A= >> +drivername=3D=0A= >> +test_suites=3D=0A= >> + l2fwd,=0A= >> + l3fwd=0A= >> +targets=3D=0A= >> + x86_64-native-linuxapp-gcc=0A= >> +parameters=3Dnic_type=3Dfortville_eagle:perf=3Dtrue=0A= >> diff --git a/framework/crb.py b/framework/crb.py=0A= >> index d41f51b..efd23b2 100644=0A= >> --- a/framework/crb.py=0A= >> +++ b/framework/crb.py=0A= >> @@ -150,7 +150,11 @@ class Crb(object):=0A= >> self.send_expect("modprobe e1000e", "# ", 20)=0A= >> self.send_expect("modprobe e1000", "# ", 20)=0A= >> self.send_expect("modprobe virtio_net", "# ", 20)=0A= >> -=0A= >> + =0A= >> + self.send_expect("modprobe i40e", "# ", 60)=0A= >> + out =3D self.send_expect("lsmod |grep i40e", "# ", 30)=0A= >> + if "i40e" not in out:=0A= >> + self.logger.error("please check the os install i40e driver a= lready.");=0A= >> try:=0A= >> for (pci_bus, pci_id) in self.pci_devices_info:=0A= >> """=0A= >> @@ -173,6 +177,9 @@ class Crb(object):=0A= >> self.send_expect("echo -n 0000:%s > /sys/bus/pc= i/drivers/e1000/bind" % pci_bus, "# ")=0A= >> elif pci_id in ('1af4:1000'):=0A= >> self.send_expect("echo 0000%s > /sys/bus/pci/driver= s/virtio-pci/bind" % pci_bus, "# ")=0A= >> + elif pci_id in ('8086:1583','8086:1584','8086:1572'):= =0A= >> + if not os.path.exists("/sys/bus/pci/drivers/i40e/"+= "0000:"+pci_bus):=0A= =0A= You need to remove this line I think, not acceptable, as you =0A= os.path.exists, then why need self.send_expect() ?=0A= =0A= Actually, all these lines will be removed later.=0A= =0A= Thanks,=0A= Michael=0A= >> + self.send_expect("echo 0000:%s > /sys/bus/pci/d= rivers/i40e/bind" % pci_bus, "# ")=0A= >> else:=0A= >> continue=0A= >> =0A= >> diff --git a/framework/settings.py b/framework/settings.py=0A= >> index 2ef8db8..40b81fb 100644=0A= >> --- a/framework/settings.py=0A= >> +++ b/framework/settings.py=0A= >> @@ -55,6 +55,9 @@ NICS =3D {=0A= >> 'I217LM': '8086:153a',=0A= >> 'I218V': '8086:1559',=0A= >> 'I218LM': '8086:155a',=0A= >> + 'fortville_eagle': '8086:1572',=0A= >> + 'fortville_spirit': '8086:1583',=0A= >> + 'fortville_spirit_single': '8086:1584',=0A= >> }=0A= >> =0A= >> DRIVERS =3D {=0A= >> @@ -80,6 +83,9 @@ DRIVERS =3D {=0A= >> 'I217LM': 'igb',=0A= >> 'I218V': 'igb',=0A= >> 'I218LM': 'igb',=0A= >> + 'fortville_eagle': 'i40e',=0A= >> + 'fortville_spirit': 'i40e',=0A= >> + 'fortville_spirit_single':'i40e'=0A= >> }=0A= >> =0A= >> """=0A= >> diff --git a/framework/test_case.py b/framework/test_case.py=0A= >> index 706003f..07fdc36 100644=0A= >> --- a/framework/test_case.py=0A= >> +++ b/framework/test_case.py=0A= >> @@ -76,5 +76,9 @@ class TestCase(object):=0A= >> bitrate *=3D 10 # 10 Gb NICs=0A= >> elif self.nic =3D=3D "avoton2c5":=0A= >> bitrate *=3D 2.5 # 2.5 Gb NICs=0A= >> + elif self.nic in ["fortville_spirit", "fortville_spirit_single"= ]:=0A= >> + bitrate *=3D 40=0A= >> + elif self.nic =3D=3D 'fortville_eagle':=0A= >> + bitrate *=3D 10=0A= >> =0A= >> return bitrate * num_ports / 8 / (frame_size + 20)=0A= >=0A= =0A=