test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Liu, Yong" <yong.liu@intel.com>, "dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] framework: enable DUT and Tester run in the same	platform
Date: Wed, 4 Feb 2015 03:18:20 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CD42BF@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <1422325266-11099-1-git-send-email-yong.liu@intel.com>

Hi, Marvin

Please send out with the pattern [PATCH v2] next time for new version patch.

Acked-by: Michael Qiu <michael.qiu@intel.com>
On 1/27/2015 10:21 AM, Yong Liu wrote:
> Skip to ping self port when DUT and Tester in the same platform.
> Not support software performance in the same platform now.
>
> Signed-off-by: Yong Liu <yong.liu@intel.com>
> ---
> This patch based on "[PATCH 0/4] Support additional port configuration file".
>
>  framework/tester.py | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/framework/tester.py b/framework/tester.py
> index 345ab41..9100967 100644
> --- a/framework/tester.py
> +++ b/framework/tester.py
> @@ -73,6 +73,8 @@ class Tester(Crb):
>          self.scapyCmds = []
>          self.bgCmds = []
>          self.bgItf = ''
> +        self.packet_gen = None
> +        self.ixia_packet_gen = None
>  
>      def init_ext_gen(self):
>          """
> @@ -287,6 +289,11 @@ class Tester(Crb):
>                  if hits[localPort]:
>                      continue
>  
> +                # skip ping self port
> +                if (self.crb['IP'] == self.crb['tester IP']) and \
> +                    (self.dut.ports_info[dutPort]['pci'] == self.ports_info[localPort]['pci']):
> +                    continue
> +
>                  ipv6 = self.dut.get_ipv6_address(dutPort)
>                  if ipv6 == "Not connected":
>                      continue
> @@ -440,6 +447,7 @@ class Tester(Crb):
>          """
>          if not self.has_external_traffic_generator():
>              self.alt_session.send_expect('killall scapy 2>/dev/null; echo tester', '# ', 5)
> +        if self.packet_gen:
>              super(Tester, self).kill_all()
>  
>      def close(self):


      reply	other threads:[~2015-02-04  3:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-26  4:52 [dts] [PATCH] framework: DUT and Tester coexisted " Yong Liu
2015-01-26  5:03 ` Qiu, Michael
2015-01-26  5:09 ` Qiu, Michael
2015-01-26  5:12   ` Liu, Yong
2015-01-27  2:21 ` [dts] [PATCH] framework: enable DUT and Tester run " Yong Liu
2015-02-04  3:18   ` Qiu, Michael [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E60286CD42BF@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=dts@dpdk.org \
    --cc=yong.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).