test suite reviews and discussions
 help / color / mirror / Atom feed
From: "Qiu, Michael" <michael.qiu@intel.com>
To: "Tang, HaifengX" <haifengx.tang@intel.com>,
	"dts@dpdk.org" <dts@dpdk.org>
Subject: Re: [dts] [PATCH] add x86_x32 abi target support
Date: Fri, 6 Feb 2015 06:23:46 +0000	[thread overview]
Message-ID: <533710CFB86FA344BFBF2D6802E60286CE3845@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <DF029FFF923C334FAA58CEEB2979DCA6014F0044@SHSMSX103.ccr.corp.intel.com>

On 2015/2/6 13:43, Tang, HaifengX wrote:
> You can find it dpdk code :config/defconfig_x86_x32_native-linuxapp-gcc
> When u have merged the patch into the code.
> http://dpdk.org/ml/archives/dev/2014-November/008111.html

What I mean is you could explain it your commit log


>
> -----Original Message-----
> From: Qiu, Michael 
> Sent: Friday, February 06, 2015 1:05 PM
> To: Tang, HaifengX; dts@dpdk.org
> Subject: Re: [dts] [PATCH] add x86_x32 abi target support
>
> On 2/6/2015 10:02 AM, Haifeng Tang wrote:
>> From: tanghaix <haifengx.tang@intel.com>
> Better to explain, what x86_x32 abi target is,  also better to add some commit log here.
>
>
>> Signed-off-by: tanghaix <haifengx.tang@intel.com>
>> ---
>>  framework/dut.py |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/framework/dut.py b/framework/dut.py index 
>> 9879335..1db6722 100644
>> --- a/framework/dut.py
>> +++ b/framework/dut.py
>> @@ -195,6 +195,9 @@ class Dut(Crb):
>>                  arch_huge_pages = hugepages if hugepages > 0 else 1024
>>              elif self.architecture == "i686":
>>                  arch_huge_pages = hugepages if hugepages > 0 else 512
>> +            #set huge pagesize for x86_x32 abi target
>> +            elif self.architecture == "x86_x32":
> Where you get "x86_x32"? from "uname"?
>
> Thanks,
> Michael
>
>
>> +                arch_huge_pages = hugepages if hugepages > 0 else 256
>>  
>>              total_huge_pages = self.get_total_huge_pages()
>>  
>


      reply	other threads:[~2015-02-06  6:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-06  2:00 Haifeng Tang
2015-02-06  5:05 ` Qiu, Michael
2015-02-06  5:43   ` Tang, HaifengX
2015-02-06  6:23     ` Qiu, Michael [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=533710CFB86FA344BFBF2D6802E60286CE3845@SHSMSX101.ccr.corp.intel.com \
    --to=michael.qiu@intel.com \
    --cc=dts@dpdk.org \
    --cc=haifengx.tang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).