test suite reviews and discussions
 help / color / mirror / Atom feed
* [dts] [PATCH] add x86_x32 abi target support
@ 2015-02-06  2:00 Haifeng Tang
  2015-02-06  5:05 ` Qiu, Michael
  0 siblings, 1 reply; 4+ messages in thread
From: Haifeng Tang @ 2015-02-06  2:00 UTC (permalink / raw)
  To: dts

From: tanghaix <haifengx.tang@intel.com>


Signed-off-by: tanghaix <haifengx.tang@intel.com>
---
 framework/dut.py |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/framework/dut.py b/framework/dut.py
index 9879335..1db6722 100644
--- a/framework/dut.py
+++ b/framework/dut.py
@@ -195,6 +195,9 @@ class Dut(Crb):
                 arch_huge_pages = hugepages if hugepages > 0 else 1024
             elif self.architecture == "i686":
                 arch_huge_pages = hugepages if hugepages > 0 else 512
+            #set huge pagesize for x86_x32 abi target
+            elif self.architecture == "x86_x32":
+                arch_huge_pages = hugepages if hugepages > 0 else 256
 
             total_huge_pages = self.get_total_huge_pages()
 
-- 
1.7.9.5

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] add x86_x32 abi target support
  2015-02-06  2:00 [dts] [PATCH] add x86_x32 abi target support Haifeng Tang
@ 2015-02-06  5:05 ` Qiu, Michael
  2015-02-06  5:43   ` Tang, HaifengX
  0 siblings, 1 reply; 4+ messages in thread
From: Qiu, Michael @ 2015-02-06  5:05 UTC (permalink / raw)
  To: Tang, HaifengX, dts

On 2/6/2015 10:02 AM, Haifeng Tang wrote:
> From: tanghaix <haifengx.tang@intel.com>

Better to explain, what x86_x32 abi target is,  also better to add some
commit log here.


>
> Signed-off-by: tanghaix <haifengx.tang@intel.com>
> ---
>  framework/dut.py |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/framework/dut.py b/framework/dut.py
> index 9879335..1db6722 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -195,6 +195,9 @@ class Dut(Crb):
>                  arch_huge_pages = hugepages if hugepages > 0 else 1024
>              elif self.architecture == "i686":
>                  arch_huge_pages = hugepages if hugepages > 0 else 512
> +            #set huge pagesize for x86_x32 abi target
> +            elif self.architecture == "x86_x32":

Where you get "x86_x32"? from "uname"?

Thanks,
Michael


> +                arch_huge_pages = hugepages if hugepages > 0 else 256
>  
>              total_huge_pages = self.get_total_huge_pages()
>  


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] add x86_x32 abi target support
  2015-02-06  5:05 ` Qiu, Michael
@ 2015-02-06  5:43   ` Tang, HaifengX
  2015-02-06  6:23     ` Qiu, Michael
  0 siblings, 1 reply; 4+ messages in thread
From: Tang, HaifengX @ 2015-02-06  5:43 UTC (permalink / raw)
  To: Qiu, Michael, dts

You can find it dpdk code :config/defconfig_x86_x32_native-linuxapp-gcc
When u have merged the patch into the code.
http://dpdk.org/ml/archives/dev/2014-November/008111.html


-----Original Message-----
From: Qiu, Michael 
Sent: Friday, February 06, 2015 1:05 PM
To: Tang, HaifengX; dts@dpdk.org
Subject: Re: [dts] [PATCH] add x86_x32 abi target support

On 2/6/2015 10:02 AM, Haifeng Tang wrote:
> From: tanghaix <haifengx.tang@intel.com>

Better to explain, what x86_x32 abi target is,  also better to add some commit log here.


>
> Signed-off-by: tanghaix <haifengx.tang@intel.com>
> ---
>  framework/dut.py |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/framework/dut.py b/framework/dut.py index 
> 9879335..1db6722 100644
> --- a/framework/dut.py
> +++ b/framework/dut.py
> @@ -195,6 +195,9 @@ class Dut(Crb):
>                  arch_huge_pages = hugepages if hugepages > 0 else 1024
>              elif self.architecture == "i686":
>                  arch_huge_pages = hugepages if hugepages > 0 else 512
> +            #set huge pagesize for x86_x32 abi target
> +            elif self.architecture == "x86_x32":

Where you get "x86_x32"? from "uname"?

Thanks,
Michael


> +                arch_huge_pages = hugepages if hugepages > 0 else 256
>  
>              total_huge_pages = self.get_total_huge_pages()
>  

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dts] [PATCH] add x86_x32 abi target support
  2015-02-06  5:43   ` Tang, HaifengX
@ 2015-02-06  6:23     ` Qiu, Michael
  0 siblings, 0 replies; 4+ messages in thread
From: Qiu, Michael @ 2015-02-06  6:23 UTC (permalink / raw)
  To: Tang, HaifengX, dts

On 2015/2/6 13:43, Tang, HaifengX wrote:
> You can find it dpdk code :config/defconfig_x86_x32_native-linuxapp-gcc
> When u have merged the patch into the code.
> http://dpdk.org/ml/archives/dev/2014-November/008111.html

What I mean is you could explain it your commit log


>
> -----Original Message-----
> From: Qiu, Michael 
> Sent: Friday, February 06, 2015 1:05 PM
> To: Tang, HaifengX; dts@dpdk.org
> Subject: Re: [dts] [PATCH] add x86_x32 abi target support
>
> On 2/6/2015 10:02 AM, Haifeng Tang wrote:
>> From: tanghaix <haifengx.tang@intel.com>
> Better to explain, what x86_x32 abi target is,  also better to add some commit log here.
>
>
>> Signed-off-by: tanghaix <haifengx.tang@intel.com>
>> ---
>>  framework/dut.py |    3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/framework/dut.py b/framework/dut.py index 
>> 9879335..1db6722 100644
>> --- a/framework/dut.py
>> +++ b/framework/dut.py
>> @@ -195,6 +195,9 @@ class Dut(Crb):
>>                  arch_huge_pages = hugepages if hugepages > 0 else 1024
>>              elif self.architecture == "i686":
>>                  arch_huge_pages = hugepages if hugepages > 0 else 512
>> +            #set huge pagesize for x86_x32 abi target
>> +            elif self.architecture == "x86_x32":
> Where you get "x86_x32"? from "uname"?
>
> Thanks,
> Michael
>
>
>> +                arch_huge_pages = hugepages if hugepages > 0 else 256
>>  
>>              total_huge_pages = self.get_total_huge_pages()
>>  
>


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2015-02-06  6:23 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-06  2:00 [dts] [PATCH] add x86_x32 abi target support Haifeng Tang
2015-02-06  5:05 ` Qiu, Michael
2015-02-06  5:43   ` Tang, HaifengX
2015-02-06  6:23     ` Qiu, Michael

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).