From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 3CC582C7A for ; Tue, 10 Feb 2015 07:10:39 +0100 (CET) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 09 Feb 2015 22:10:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.09,548,1418112000"; d="scan'208";a="649881096" Received: from pgsmsx107.gar.corp.intel.com ([10.221.44.105]) by orsmga001.jf.intel.com with ESMTP; 09 Feb 2015 22:10:36 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.110.14) by PGSMSX107.gar.corp.intel.com (10.221.44.105) with Microsoft SMTP Server (TLS) id 14.3.195.1; Tue, 10 Feb 2015 14:10:15 +0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.192]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.197]) with mapi id 14.03.0195.001; Tue, 10 Feb 2015 14:10:14 +0800 From: "Qiu, Michael" To: "Iremonger, Bernard" , "dts@dpdk.org" Thread-Topic: [PATCH] test_plan: add hotplug_test_plan Thread-Index: AQHQPsTXSPmZsjvrL02oMBr5A1mZQw== Date: Tue, 10 Feb 2015 06:10:14 +0000 Message-ID: <533710CFB86FA344BFBF2D6802E60286CE75F8@SHSMSX101.ccr.corp.intel.com> References: <1422866813-23729-1-git-send-email-michael.qiu@intel.com> <533710CFB86FA344BFBF2D6802E60286CE7206@SHSMSX101.ccr.corp.intel.com> <8CEF83825BEC744B83065625E567D7C2049DF16C@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dts] [PATCH] test_plan: add hotplug_test_plan X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Feb 2015 06:10:40 -0000 On 2/10/2015 12:27 AM, Iremonger, Bernard wrote:=0A= >> -----Original Message-----=0A= >> From: Qiu, Michael=0A= >> Sent: Monday, February 9, 2015 1:14 PM=0A= >> To: dts@dpdk.org=0A= >> Cc: mukawa@igel.co.jp; Iremonger, Bernard=0A= >> Subject: Re: [PATCH] test_plan: add hotplug_test_plan=0A= >>=0A= >> [+cc] Bernard=0A= >>=0A= >> Hi, Bernard and Tetsuya=0A= >>=0A= >> Would you have time to review this test plan?=0A= > Hi Michael,=0A= >=0A= > Yes, my comments are inline.=0A= =0A= OK, I will fix all typo.=0A= =0A= Thanks,=0A= Michael=0A= >> Your comments are very important.=0A= >>=0A= >> Thanks,=0A= >> Michael=0A= >> On 2/2/2015 4:47 PM, Qiu, Michael wrote:=0A= >>> As hotplug feature will be supported by DPDK 2.0, the test plan is=0A= >>> needed for testing affairs, this could help who wants to do hotplug=0A= >>> testing for their projects.=0A= >>>=0A= >>> Signed-off-by: Michael Qiu =0A= >>> ---=0A= >>> test_plans/hotplug_test_plan.rst | 152=0A= >>> +++++++++++++++++++++++++++++++++++++++=0A= >>> 1 file changed, 152 insertions(+)=0A= >>> create mode 100644 test_plans/hotplug_test_plan.rst=0A= >>>=0A= >>> diff --git a/test_plans/hotplug_test_plan.rst=0A= >>> b/test_plans/hotplug_test_plan.rst=0A= >>> new file mode 100644=0A= >>> index 0000000..63c3d70=0A= >>> --- /dev/null=0A= >>> +++ b/test_plans/hotplug_test_plan.rst=0A= >>> @@ -0,0 +1,152 @@=0A= >>> +.. Copyright (c) <2015>, Intel Corporation=0A= >>> + All rights reserved.=0A= >>> +=0A= >>> + Redistribution and use in source and binary forms, with or without= =0A= >>> + modification, are permitted provided that the following conditions= =0A= >>> + are met:=0A= >>> +=0A= >>> + - Redistributions of source code must retain the above copyright=0A= >>> + notice, this list of conditions and the following disclaimer.=0A= >>> +=0A= >>> + - Redistributions in binary form must reproduce the above copyright= =0A= >>> + notice, this list of conditions and the following disclaimer in= =0A= >>> + the documentation and/or other materials provided with the=0A= >>> + distribution.=0A= >>> +=0A= >>> + - Neither the name of Intel Corporation nor the names of its=0A= >>> + contributors may be used to endorse or promote products derived= =0A= >>> + from this software without specific prior written permission.=0A= >>> +=0A= >>> + THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS= =0A= >>> + "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT= =0A= >>> + LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS= =0A= >>> + FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE=0A= >>> + COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,= =0A= >>> + INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES=0A= >>> + (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR= =0A= >>> + SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)= =0A= >>> + HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT,= =0A= >>> + STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)=0A= >>> + ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED= =0A= >>> + OF THE POSSIBILITY OF SUCH DAMAGE.=0A= >>> +=0A= >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= >>> +DPDK Hotplug API Feature Tests=0A= >>> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A= >>> +=0A= >>> +This test for Hotplug API feature can be run on linux userspace. It=0A= >>> +will check if NIC port can be attach and detach without exiting the=0A= > Reword "can be attach and detach" to "can be attached and detached"=0A= >=0A= >>> +application process. Furthermore, it will check if it can reconfigure= =0A= >>> +new configurations for a port after the port is stopped, and if it is= =0A= >>> +able to restart with those new configurations. It is based on testpmd= =0A= >>> +application.=0A= >>> +=0A= >>> +The test is performed by running the testpmd application and using a= =0A= >>> +traffic generator. Port configurations can be set interactively, and= =0A= >>> +still be set at the command line when launching the application in=0A= >>> +order to be compatible with previous test framework.=0A= >>> +=0A= >>> +Prerequisites=0A= >>> +-------------=0A= >>> +Assume DPDK managerd at least one device for physical or none for virt= ual.=0A= > Reword "managerd" to "managed"=0A= >=0A= >>> +This feature only supports igb_uio now, for uio_pci_generic is on the= =0A= >>> +way, will test it after enabled.=0A= >>> +=0A= >>> +To run the testpmd application in linuxapp environment with 4 lcores,= =0A= >>> +4 channels with other default parameters in interactive mode.=0A= >>> +=0A= >>> + $ ./testpmd -c 0xf -n 4 -- -i=0A= >>> +=0A= >>> +Test ENV:=0A= >>> +=0A= >>> +All test case can be run in 32bit and 64bit platform.=0A= > Reword "case" to "cases"=0A= >=0A= >>> +=0A= >>> +All os can be support, like fedora, ubuntu, rhel, suse, but freebsd=0A= > Reword "All os can be support" to "All os's can be supported"=0A= >=0A= >>> +will not include as hotplug has no plan to support that platform=0A= > Reword "will not include" to "will not be included".=0A= >=0A= >>> +=0A= >>> +All kernel version(start from 2.6) can be support, for vfio need kerne= l=0A= > Reword " All kernel version(start from 2.6) can be support" to "All kerne= l versions(from 2.6) can be supported"=0A= >=0A= >>> + version greater than 3.6.=0A= >>> +=0A= >>> +Virtulization support: KVM/VMware/Xen, container is in the roadmap=0A= >>> +=0A= >>> +---------------------------------------------------------------------= =0A= >>> +---------- Test Case 1: port dettach & attach for physical devices=0A= > Reword "dettach" to "detach"=0A= >=0A= >>> +with igb_uio=0A= >>> +---------------------------------------------------------------------= =0A= >>> +----------=0A= >>> +1. run "port attach 0000:02:00.0",=0A= >>> + assume the physical devices is BDF is 0000:02:00.0=0A= >>> +=0A= >>> +2. run "port start 0".=0A= >>> +=0A= >>> +3. run "show port info 0", check port 0 info display.=0A= >>> +=0A= >>> +4. run "start", then "show port stats 0" check fwd packages start.=0A= >>> +=0A= >>> +5. run "port detach 0", check the error message of port not stopped.= =0A= >>> +=0A= >>> +6. run "stop", then "show port stats 0", check fwd packages stoped.=0A= > Reword "stoped" to "stopped"=0A= >=0A= >>> +=0A= >>> +7. run "port close 0".=0A= >>> +=0A= >>> +8. run "port detach 0", check port detached successful.=0A= > Should probably have a test case to attach a port again after it has been= detached.=0A= >=0A= >>> +=0A= >>> +---------------------------------------------------------------------= =0A= >>> +---------- Test Case 2: port dettach & attach for physical devices=0A= > Reword "dettach" to "detach"=0A= >=0A= >>> +with vfio=0A= >>> +---------------------------------------------------------------------= =0A= >>> +----------=0A= >>> +1. run "port attach 0000:02:00.0",=0A= >>> + assume the physical devices is BDF is 0000:02:00.0=0A= >>> +=0A= >>> +2. run "port start 0".=0A= >>> +=0A= >>> +3. run "show port info 0", check port 0 info display.=0A= >>> +=0A= >>> +4. run "start", then "show port stats 0" check fwd packages start.=0A= >>> +=0A= >>> +5. run "port detach 0", check the error message of port not stopped.= =0A= >>> +=0A= >>> +6. run "stop", then "show port stats 0", check fwd packages stoped.=0A= > Reword "stoped" to "stopped" =0A= >>> +=0A= >>> +7. run "port close 0".=0A= >>> +=0A= >>> +8. run "port detach 0", check port detached failed(If hotplug for vfio= =0A= >>> + implemented, should be successful).=0A= > This should fail as no detach support at the moment for vfio.=0A= >=0A= >>> +=0A= >>> +---------------------------------------------------------------------= =0A= >>> +---------- Test Case 3: port dettach & attach for physical devices=0A= > Reword "dettach" to detach.=0A= >=0A= >>> +with uio_pci_generic=0A= >>> +---------------------------------------------------------------------= =0A= >>> +----------=0A= > There is no support for uio_pci_generic at present.=0A= > It might be better to leave this test case out until support is added.=0A= >=0A= >>> +1. run "port attach 0000:02:00.0",=0A= >>> + assume the physical devices is BDF is 0000:02:00.0=0A= >>> +=0A= >>> +2. run "port start 0".=0A= >>> +=0A= >>> +3. run "show port info 0", check port 0 info display.=0A= >>> +=0A= >>> +4. run "start", then "show port stats 0" check fwd packages start.=0A= >>> +=0A= >>> +5. run "port detach 0", check the error message of port not stopped.= =0A= >>> +=0A= >>> +6. run "stop", then "show port stats 0", check fwd packages stoped.=0A= > Reword "stoped" to "stopped"=0A= >=0A= >>> +=0A= >>> +7. run "port close 0".=0A= >>> +=0A= >>> +8. run "port detach 0", check port detached successful.=0A= >>> +=0A= >>> +---------------------------------------------------------------------= =0A= >>> +---------- Test Case 4: port dettach & attach for virtual devices=0A= > Reword "dettach" to detach.=0A= >=0A= >>> +---------------------------------------------------------------------= =0A= >>> +---------- 1. run "port attach eth_pcap0,iface=3Dxxxx", where "xxxx" i= s=0A= >>> +one workable ifname.=0A= >>> +=0A= >>> +2. run "port start 0".=0A= >>> +=0A= >>> +3. run "show port info 0", check port 0 info display.=0A= >>> +=0A= >>> +4. run "start", then "show port stats 0" check fwd packages start.=0A= >>> +=0A= >>> +5. run "port detach 0", check the error message of port not stopped.= =0A= >>> +=0A= >>> +6. run "stop", then "show port stats 0", check fwd packages stoped.=0A= > Reword "stoped" to "stopped"=0A= >=0A= >>> +=0A= >>> +7. run "port close 0".=0A= >>> +=0A= >>> +8. run "port detach 0", check port detached successful.=0A= >>> +=0A= >>> +successfully=0A= > Should probably have a test case to attach a virtual port again after it = has been detached.=0A= >=0A= > Regards,=0A= >=0A= > Bernard.=0A= >=0A= =0A=